Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc lint #9164

Merged
merged 8 commits into from
Mar 29, 2024
Merged

misc lint #9164

merged 8 commits into from
Mar 29, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 28, 2024

closes: #4620

Description

Follow up to #9149

Review by commit is suggested

Security Considerations

n/a, just linting

Scaling Considerations

n/a, just linting

Documentation Considerations

Nothing to write. Fewer gotchas

Testing Considerations

  • no IDE errors

Upgrade Considerations

Some "re-exports" are no longer available. Downstream will have to get the type from the source package. That will not affect their dependencies because the higher package already transitively required the lower one.

Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome!

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Mar 29, 2024
@mergify mergify bot merged commit 59738aa into master Mar 29, 2024
74 checks passed
@mergify mergify bot deleted the ta/moar-import branch March 29, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type checker in IDE and CLI/CI sometimes disagree
2 participants