replace jsconfig with tsconfig #8179
Conversation
jsconfig had defaults that now have to be explicit, but we don't need to be as permissive as the jsconfig was
There was a problem hiding this comment.
Just one comment I'd like an opinion on. Otherwise, nice and boring! 😉
Maybe wait for @mhofman, too if you wish.
| @@ -1,5 +1,9 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
| "compilerOptions": { | |||
| "allowSyntheticDefaultImports": true, | |||
There was a problem hiding this comment.
Looking at the documentation for allowSyntheticDefaultImports, it seems like a bad practice to depend on it, and we should probably fix our code instead.
Did that turn out to be too much work, or would you like to address that change in a future PR? Otherwise, I'd be curious about your experiences trying to turn this option off.
There was a problem hiding this comment.
They're enabled now only where turning them off caused errors. Most of them were imports of 3rd party npm packages or NodeJS built-in modules.
Something we want to move away from but out of scope of this PR. The jsconfig filename was always enabling it. At least now it's only enabled in packages that fail without it. We can burn them down over time.
replace jsconfig with tsconfig
refs: #4620
Description
To help burn down our type resolution debt, we need a way to ensure progress we make doesn't regress. The
jsconfig.jsonfiles some lax defaults: https://github.com/microsoft/TypeScript/blob/e624827f63e20096e116814a6ebfd7c8f4daed9f/src/compiler/commandLineParser.ts#L3402This changes all those files to
tsconfig.jsonso those values must be set explicitly. In doing this, I tested tighter settings and made the explicit config only as lax as it had to be for thelint:typesto pass.I also removed the now redundant
-poption totsc, sincetsconfig.jsonis its default.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
n/a