Consider updating axios #141
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [axios](https://github.com/axios/axios) from 0.25.0 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.25.0...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
+1 |
|
Note that GHSA-wf5p-g6vw-rhxx is scoped to axios instances that set I'm guessing CI is failing because axios switched to ESM at 1.0.0. |
|
|
Perhaps this project should drop support for EOL Node versions? Node 4 (On which the tests are failing) has not been supported since 2018. |
|
NOTE Hey everybody, axios recently patched CVE-2023-45857 bug, which this PR relates too. As @WestonThayer mentioned, this issue doesn't not affect Postmark Node JS, since we are not using We are checking out though direction we want to take with axios and node support, so I will keep this PR open and keep you up to date . |
|
My recommendation would be to drop support for unsupported nodejs versions and update axios. I'm assuming your HTTP API is fairly stables so old SDKs would most likely keep working for a long time for people on legacy nodejs versions. While technically axios isn't affected, everyone that's up to date on their dependencies and vulnerabilities pays the cost of researching the issue and checking if postmark.js is affected or not. Users on outdated nodejs versions have bigger issues either way and are most likely not updating and tracking dependencies anyways. |
|
Looks like axios is up-to-date now, so this is no longer needed. |
|
we have released updated version of the library and dropped support for most EOL node js versions |
Bumps axios from 0.25.0 to 1.6.0.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
... (truncated)
Commits
f7adacdchore(release): v1.6.0 (#6031)9917e67chore(ci): fix release-it arg; (#6032)96ee232fix(CSRF): fixed CSRF vulnerability CVE-2023-45857 (#6028)7d45ab2chore(tests): fixed tests to pass in node v19 and v20 withkeep-aliveenabl...5aaff53fix(dns): fixed lookup function decorator to work properly in node v20; (#6011)a48a63achore(docs): added AxiosHeaders docs; (#5932)a1c8ad0fix(types): fix AxiosHeaders types; (#5931)2ac731dchore(docs): update readme.md (#5889)88fb52bchore(release): v1.5.1 (#5920)e410779fix(adapters): improved adapters loading logic to have clear error messages; ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.