-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Dusting off the manifold stuff #492
Draft
baperry2
wants to merge
94
commits into
AMReX-Combustion:development
Choose a base branch
from
baperry2:last-manifold-rebase
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Dusting off the manifold stuff #492
baperry2
wants to merge
94
commits into
AMReX-Combustion:development
from
baperry2:last-manifold-rebase
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baperry2
force-pushed
the
last-manifold-rebase
branch
3 times, most recently
from
May 2, 2024 21:49
41029b3
to
6e8eb5d
Compare
Still need to generalize TabFuncParams and TabFuncData and work the neural net into the existing EoS framework
- Moved get_var_index to ManifoldFunc.H instead of EosParams.H - Shortened get_var_index arglist
- Still need to calculate source terms - Still need to account for variables passed to input layer - Maybe we can worry about GPUs later
- This style of manifold will print all of the metadata properly, but SEGFAULTs at some point in EosEval/main.cpp
Combined Source Term lookups
…cs into kiraneiden/manifold
baperry2
force-pushed
the
last-manifold-rebase
branch
from
May 17, 2024 23:57
5a8b6c3
to
0be40cd
Compare
final compilation change for no manifold with sycl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes new capability to define black box function (either a table or a neural network) and use this function in an EOS.
Still some cleaning up that needs to get done.
Co-authored by: @KiranEiden