Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #899 #991

Open
wants to merge 3 commits into
base: hotfix/5.22
Choose a base branch
from
Open

Closes #899 #991

wants to merge 3 commits into from

Conversation

NathanGibbs3
Copy link
Contributor

Fixes Issue #899 in the 5.22x branch.

dregad
dregad approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@dregad dregad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mnewnham I know you're busy, but if you can spare the time just have a look to confirm this is in line with what you had in mind when you opened #899. Without feedback from you I'll merge the PR at the end of the week.

@NathanGibbs3 NathanGibbs3 mentioned this pull request Jun 29, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dregad dregad dregad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanGibbs3 @dregad