MySQL MetaColumns() behavior. #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetaColumns is called. Besides eliminating a pair of queries (albeit very cheap ones), it reduces the chances of MetaColumns silently altering the connection state in the event of an error. I added the same behavior for mysqli because it seemed strange for only 2/3 options to support "schema.table" syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mysql and pdo_mysql drivers will check for a schema in the argument and if found will change the connection's selected schema, get the table information, and change the connection's selected schema back. I think that's unnecessarily complicated. Manipulating the state of the connection creates the possibility of giving it back to the caller in a different state and it's not strictly necessary anyway. This change also detects a schema in the argument but modifies the metaColumnsSQL string rather than modifying the connection.
I added the same behavior for mysqli because it seemed strange for only 2 out of 3 options to support "schema.table" syntax.