Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AllowDynamicProperties attribute on ADOFetchObj class. #975

Closed

Conversation

hschletz
Copy link
Contributor

Avoid deprecation warning on PHP 8.2.

Avoid deprecation warning on PHP 8.2.
@dregad dregad added bug PHP8.2 PHP8.2 Compatibility Issues labels May 24, 2023
@dregad dregad added this to the v5.22.6 milestone May 24, 2023
@dregad dregad removed bug PHP8.2 PHP8.2 Compatibility Issues labels Jun 10, 2023
@dregad dregad removed this from the v5.22.6 milestone Jun 10, 2023
@dregad
Copy link
Member

dregad commented Jun 11, 2023

Thanks for your contribution.

I'm going to merge this as a temporary workaround, as I'd rather have this issue fixed more cleanly, by adding magic methods in ADOFetchObj class. I opened #982 to track that.

@dregad dregad changed the base branch from master to hotfix/5.22 June 11, 2023 00:01
@dregad dregad changed the base branch from hotfix/5.22 to master June 11, 2023 00:02
dregad pushed a commit that referenced this pull request Jun 11, 2023
Avoid deprecation warning on PHP 8.2.

Fixes #975, as temporary workaround for #982

Signed-off-by: Damien Regad <dregad@mantisbt.org>
@dregad
Copy link
Member

dregad commented Jun 11, 2023

Since your PR was targeted at master branch and I wanted this to go in hotfix/5.22, I cherry-picked the commit (1fbd7f1).

@dregad dregad closed this Jun 11, 2023
@dregad dregad added bug PHP8.2 PHP8.2 Compatibility Issues labels Jun 11, 2023
@dregad dregad self-assigned this Jun 11, 2023
@dregad dregad added this to the v5.22.6 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants