Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring ADOFetchObj class to use magic methods #982

Closed
dregad opened this issue Jun 10, 2023 · 1 comment
Closed

Refactoring ADOFetchObj class to use magic methods #982

dregad opened this issue Jun 10, 2023 · 1 comment
Assignees
@dregad
Labels
code cleanup enhancement PHP8.2 PHP8.2 Compatibility Issues
Milestone
v5.23.0

Comments

@dregad
Copy link
Member

dregad commented Jun 10, 2023

Occurs e.g. when calling ADORecordSet::fetchObj() / fetchNextObj()

Initially reported by @hschletz in PR #975
@dregad dregad added the PHP8.2 PHP8.2 Compatibility Issues label Jun 10, 2023
@dregad dregad added this to the v5.22.6 milestone Jun 10, 2023
@dregad dregad self-assigned this Jun 10, 2023
@dregad dregad added the bug label Jun 10, 2023
@dregad dregad mentioned this issue Jun 11, 2023
Closed
dregad pushed a commit that referenced this issue Jun 11, 2023
@hschletz @dregad
Set AllowDynamicProperties attribute on ADOFetchObj class
1fbd7f1 
Avoid deprecation warning on PHP 8.2.

Fixes #975, as temporary workaround for #982

Signed-off-by: Damien Regad <dregad@mantisbt.org>
@dregad dregad modified the milestones: v5.22.6, v5.23.0 Jun 11, 2023
@dregad
Copy link
Member Author

dregad commented Jun 11, 2023 •
edited

Recategorizing this as a refactoring, and targeting to 5.23.0.

The AllowDynamicProperties fix (#975) is enough for the PHP 8.2 compatibility, and this reduces the risk of introducing regression in a hotfix release.

@dregad dregad changed the title Deprecated: Creation of dynamic property ADOFetchObj::$xxx Refactoring ADOFetchObj class to use magic methods Jun 11, 2023
@dregad dregad closed this as completed in 8bc38a1 Jun 11, 2023
dregad added a commit that referenced this issue Jun 11, 2023
@dregad
Refactor fetchObject, remove unused properties
affb454 
Code is simplified using the new ADOFieldObj constructor.

The ADORecordSet properties $_obj and $_names are no longer needed and
have been removed.

Issue #982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dregad dregad

Labels
code cleanup enhancement PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Milestone
v5.23.0
Development

No branches or pull requests
1 participant
@dregad