Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the PostgreSQL driver #955

Open
dregad opened this issue Apr 15, 2023 · 0 comments · May be fixed by #1008
Open

Refactor the PostgreSQL driver #955

dregad opened this issue Apr 15, 2023 · 0 comments · May be fixed by #1008
Labels
Milestone

Comments

@dregad
Copy link
Member

dregad commented Apr 15, 2023

ADOdb's original PostgreSQL driver goes back to version 6.4 (adodb-postgres64.inc.php). Over the years, it has been overloaded several times to adapt it to changes in later releases of the database (postgres7, postgres8, postgres9), and some of these child classes are just empty shells. Additionally, some compatibility fixes were implemented in the base class, using version checks.

All of these changes obsolete today, since even PostgreSQL 10 reached end-of-life in of November 2022 [1]. They should be removed from the code, as proposed by @Mike-Benoit in #950.

Moreover, it is no longer necessary to keep the version-specific drivers. They should be merged into a single, flattened class supporting current PosgreSQL releases.

@dregad dregad added this to the v5.23.0 milestone Apr 15, 2023
@dregad dregad linked a pull request Nov 5, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant