pgsql: metaTables() returns duplicated views

[dregad]

Description

When executed with $ttype = false on PostgreSQL driver, database views are listed twice in the array returned by metaTables() method.

Environment

• ADOdb version: 5.22.5
• Driver or Module: postgres
• Database type and version: PostgreSQL > 7.3
• PHP version: any
• Platform: any

• I have tested that the problem is reproducible in the master branch and hotfix branch

Steps to reproduce

A database containing at least one view (here, I have 2 tables test, test2 and a view v_test2)

print_r($db->metaTables();

Script output

Array
(
    [0] => v_test2
    [1] => test
    [3] => test2
    [4] => v_test2
)

Expected behavior

List all tables and views without duplicates

[dregad]

This bug is present since v5.12, when commit 511d2da introduced use of information_schema instead of pg_catalog to retrieve tables metadata.

Considering how long it's been out there without anyone complaining about it, and the pending refactor of PostgreSQL driver (#955), I'm targeting this at 5.23 instead of the hotfix branch as I normally would.