Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for code generation while using goField and goModel tags together for one type. #3562

Merged

Conversation

atzedus
Copy link
Contributor

@atzedus atzedus commented Feb 25, 2025

Example code:

type AdFormatAlias @goModel(forceGeneration: true) {
    id: ID!
    name: String!
    organization: Organization! @goField(forceResolver: true)
}

In this combination @GoModel tag is loosing, because map entry fully rewrited without copy property ForceGenerate.

This PR fixes this issue and (hopefully) prevents such problems in the future.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
tmihoc Teodora Mihoc
@coveralls
Copy link

Coverage Status

coverage: 73.535% (-0.06%) from 73.597%
when pulling 26e7311 on atzedus:bugfix_for_go_field_tag_generation
into 5310d08 on 99designs:master.

@StevenACoffman StevenACoffman merged commit e3fd580 into 99designs:master Feb 25, 2025
24 checks passed
@atzedus atzedus deleted the bugfix_for_go_field_tag_generation branch February 25, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants