Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: go mod update #212

Merged
merged 3 commits into from Jun 20, 2023
Merged

enhancement: go mod update #212

merged 3 commits into from Jun 20, 2023

Conversation

tomtwinkle
Copy link
Contributor

@tomtwinkle tomtwinkle commented Jun 20, 2023

Fixed the NotFound decision function.

Bug Fix: Fix HeadObject to return types.Nound when an object does not exist. Fixes aws/aws-sdk-go-v2#2084

https://github.com/aws/aws-sdk-go-v2/blob/release-2023-06-13/service/s3/CHANGELOG.md#v1340-2023-06-13

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #212 (5712a11) into main (c0841da) will increase coverage by 1.67%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   70.05%   71.72%   +1.67%     
==========================================
  Files          16       17       +1     
  Lines         788      824      +36     
==========================================
+ Hits          552      591      +39     
+ Misses        189      186       -3     
  Partials       47       47              
Impacted Files Coverage Δ
aws/awss3/awss3.go 74.70% <50.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

@tomtwinkle tomtwinkle merged commit bacbcbc into main Jun 20, 2023
4 checks passed
@tomtwinkle tomtwinkle deleted the enhancement-go-mod-update branch June 20, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 HeadObject still doesn't return types.NotFound error
1 participant