Add From<ChatCompletionRequestDeveloperMessage> implementation for ChatCompletionRequestMessage
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etionRequestMessage` Appears to have been left out of 64bit#312
|
#319 might supersede depending on maintainer being willing to take another dependency |
64bit
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Thank you for both contributions!
I'll happily accept both, for #319 because its adding new dependency I'd appreciate if we use the value it provides more, there are a lot of Enums in the crate and seems like derive_more::From can be applied to all of them.
ifsheldon
pushed a commit
to ifsheldon/async-openai-wasm
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to use the new
ChatCompletionRequestDeveloperMessageadded in #312, I found I couldn't use.into()to add it tomessagesbecause aFrom<ChatCompletionRequestDeveloperMessage>implementation forChatCompletionRequestMessagewasn't available.