This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
chore: Namespace Selection #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvah
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Hi @Kells512!
I have some minor comments before merging this one.
Could you please group all the Namespace variants in a single folder?
You could also move it inside src/app/components/POCs, I think.
Just to keep things more organized.
Also I've noticed that you added a git submodule in a new sandbox-ui empty folder. I guess it wasn't intentional. If so, could you get rid of it?
Comment on lines
+6
to
+18
| export default { | ||
| title: "PoCs/Namespace 2", | ||
| component: ComposableContextSelector, | ||
| args: {}, | ||
| decorators: [], | ||
| } as ComponentMeta<typeof ComposableContextSelector>; | ||
|
|
||
| const Template: ComponentStory<typeof ComposableContextSelector> = (args) => ( | ||
| <ComposableContextSelector {...args} /> | ||
| ); | ||
|
|
||
| export const Story = Template.bind({}); | ||
| Story.args = {}; |
There was a problem hiding this comment.
I think it would be nicer if all the Namespace stories were grouped in a single "folder" within Storybook.
To do so it's enough to provide the same title to all of them, like title: "PoCs/Namespace"
Then you can give each story a different name by doing something like this:
export const Namespace2 = Template.bind({});
Namespace2.args = {};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.