Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Button): MUI剥がし #1579

Open
wants to merge 6 commits into
base: refactor/remove-mui@1553
Choose a base branch
from

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented May 6, 2024

チケット

実装内容

  • Button: MUIを剥がした

スクリーンショット

変更前 変更後

相談内容(あれば)

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 937c35b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-pages bot commented May 6, 2024

Deploying for-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 937c35b
Status: ✅  Deploy successful!
Preview URL: https://8d9a7605.for-ui.pages.dev
Branch Preview URL: https://refactor-remove-mui-button-1.for-ui.pages.dev

View logs

Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

CI Failure Feedback 🧐

Action: build-vite

Failed stage: Run npm run build [❌]

Failure summary:

The action failed due to TypeScript compilation errors where multiple parameters were implicitly
typed as 'any'. Specifically, errors occurred in the following files and lines:

  • src/drawer/Drawer.tsx line 228
  • src/snackbar/Snackbar.tsx line 153
  • src/table/TablePagination.tsx lines 191, 206, 221, 236
    These errors prevented the build:types script
    from completing successfully, leading to a failure in the overall build process.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    410:  > tsc -p tsconfig.build.json
    411:  �[36mvite v4.0.4 �[32mbuilding for production...�[36m�[39m
    412:  transforming...
    413:  �[32m✓�[39m 107 modules transformed.
    414:  rendering chunks...
    415:  computing gzip size...
    416:  �[2mdist/commonjs/�[22m�[36mfor-ui.js  �[39m�[1m�[2m85.94 kB�[22m�[1m�[22m�[2m │ gzip: 25.08 kB�[22m
    417:  �[2mdist/esm/�[22m�[36mfor-ui.esm.js  �[39m�[1m�[2m148.61 kB�[22m�[1m�[22m�[2m │ gzip: 32.20 kB�[22m
    418:  ##[error]src/drawer/Drawer.tsx(228,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    419:  ##[error]src/snackbar/Snackbar.tsx(153,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    420:  ##[error]src/table/TablePagination.tsx(191,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    421:  ##[error]src/table/TablePagination.tsx(206,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    422:  ##[error]src/table/TablePagination.tsx(221,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    423:  ##[error]src/table/TablePagination.tsx(236,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    424:  npm ERR! Lifecycle script `build:types` failed with error: 
    425:  npm ERR! Error: command failed 
    426:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    427:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    428:  ERROR: "build:types" exited with 1.
    429:  npm ERR! Lifecycle script `build` failed with error: 
    430:  npm ERR! Error: command failed 
    431:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    432:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    433:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    CI Failure Feedback 🧐

    Action: build-nextjs

    Failed stage: Run npm run build [❌]

    Failure summary:

    The action failed due to TypeScript compilation errors in multiple files, where the parameter 'e'
    was implicitly typed as 'any'. This occurred in the following files and lines:

  • src/drawer/Drawer.tsx line 228
  • src/snackbar/Snackbar.tsx line 153
  • src/table/TablePagination.tsx lines 191, 206, 221, 236
    These errors prevented the TypeScript
    compiler from successfully completing, leading to a failure in the build:types script, which
    subsequently caused the entire build process to fail.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    410:  > tsc -p tsconfig.build.json
    411:  �[36mvite v4.0.4 �[32mbuilding for production...�[36m�[39m
    412:  transforming...
    413:  �[32m✓�[39m 107 modules transformed.
    414:  rendering chunks...
    415:  computing gzip size...
    416:  �[2mdist/commonjs/�[22m�[36mfor-ui.js  �[39m�[1m�[2m85.94 kB�[22m�[1m�[22m�[2m │ gzip: 25.08 kB�[22m
    417:  �[2mdist/esm/�[22m�[36mfor-ui.esm.js  �[39m�[1m�[2m148.61 kB�[22m�[1m�[22m�[2m │ gzip: 32.20 kB�[22m
    418:  ##[error]src/drawer/Drawer.tsx(228,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    419:  ##[error]src/snackbar/Snackbar.tsx(153,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    420:  ##[error]src/table/TablePagination.tsx(191,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    421:  ##[error]src/table/TablePagination.tsx(206,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    422:  ##[error]src/table/TablePagination.tsx(221,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    423:  ##[error]src/table/TablePagination.tsx(236,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    424:  npm ERR! Lifecycle script `build:types` failed with error: 
    425:  npm ERR! Error: command failed 
    426:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    427:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    428:  ERROR: "build:types" exited with 1.
    429:  npm ERR! Lifecycle script `build` failed with error: 
    430:  npm ERR! Error: command failed 
    431:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    432:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    433:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    CI Failure Feedback 🧐

    Action: build-vite

    Failed stage: Run npm run build [❌]

    Failure summary:

    The action failed due to TypeScript compilation errors in multiple files. Specifically, the
    parameter 'e' in several functions was implicitly typed as 'any', which is not allowed without
    explicit typing in strict TypeScript configurations. This caused the build:types script to fail,
    which in turn caused the entire build process to fail.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    410:  > tsc -p tsconfig.build.json
    411:  �[36mvite v4.0.4 �[32mbuilding for production...�[36m�[39m
    412:  transforming...
    413:  �[32m✓�[39m 107 modules transformed.
    414:  rendering chunks...
    415:  computing gzip size...
    416:  �[2mdist/commonjs/�[22m�[36mfor-ui.js  �[39m�[1m�[2m85.94 kB�[22m�[1m�[22m�[2m │ gzip: 25.08 kB�[22m
    417:  �[2mdist/esm/�[22m�[36mfor-ui.esm.js  �[39m�[1m�[2m148.61 kB�[22m�[1m�[22m�[2m │ gzip: 32.20 kB�[22m
    418:  ##[error]src/drawer/Drawer.tsx(228,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    419:  ##[error]src/snackbar/Snackbar.tsx(153,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    420:  ##[error]src/table/TablePagination.tsx(191,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    421:  ##[error]src/table/TablePagination.tsx(206,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    422:  ##[error]src/table/TablePagination.tsx(221,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    423:  ##[error]src/table/TablePagination.tsx(236,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    424:  npm ERR! Lifecycle script `build:types` failed with error: 
    425:  npm ERR! Error: command failed 
    426:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    427:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    428:  ERROR: "build:types" exited with 1.
    429:  npm ERR! Lifecycle script `build` failed with error: 
    430:  npm ERR! Error: command failed 
    431:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    432:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    433:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    CI Failure Feedback 🧐

    Action: build-nextjs

    Failed stage: Run npm run build [❌]

    Failure summary:

    The action failed due to TypeScript compilation errors in multiple files. Specifically, the errors
    were related to implicit 'any' types for the parameter 'e' in several components. This indicates
    that the TypeScript compiler's strict type checking settings are enabled, and the code does not meet
    these type safety requirements.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    410:  > NODE_ENV=production vite build
    411:  �[36mvite v4.0.4 �[32mbuilding for production...�[36m�[39m
    412:  transforming...
    413:  �[32m✓�[39m 107 modules transformed.
    414:  rendering chunks...
    415:  computing gzip size...
    416:  �[2mdist/commonjs/�[22m�[36mfor-ui.js  �[39m�[1m�[2m85.94 kB�[22m�[1m�[22m�[2m │ gzip: 25.08 kB�[22m
    417:  �[2mdist/esm/�[22m�[36mfor-ui.esm.js  �[39m�[1m�[2m148.61 kB�[22m�[1m�[22m�[2m │ gzip: 32.20 kB�[22m
    418:  ##[error]src/drawer/Drawer.tsx(228,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    419:  ##[error]src/snackbar/Snackbar.tsx(153,25): error TS7006: Parameter 'e' implicitly has an 'any' type.
    420:  ##[error]src/table/TablePagination.tsx(191,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    421:  ##[error]src/table/TablePagination.tsx(206,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    422:  ##[error]src/table/TablePagination.tsx(221,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    423:  ##[error]src/table/TablePagination.tsx(236,31): error TS7006: Parameter 'e' implicitly has an 'any' type.
    424:  npm ERR! Lifecycle script `build:types` failed with error: 
    425:  npm ERR! Error: command failed 
    426:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    427:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    428:  ERROR: "build:types" exited with 1.
    429:  npm ERR! Lifecycle script `build` failed with error: 
    430:  npm ERR! Error: command failed 
    431:  npm ERR!   in workspace: @4design/for-ui@1.1.11 
    432:  npm ERR!   at location: /home/runner/work/for-ui/for-ui/packages/for-ui 
    433:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @Qs-F Qs-F marked this pull request as ready for review May 11, 2024 07:55
    @Qs-F Qs-F requested a review from locona May 11, 2024 07:55
    @Qs-F Qs-F marked this pull request as draft May 11, 2024 07:55
    @Qs-F Qs-F removed the request for review from locona May 11, 2024 07:56
    @Qs-F Qs-F changed the base branch from main to refactor/remove-mui@1553 May 11, 2024 08:03
    @Qs-F Qs-F marked this pull request as ready for review May 11, 2024 08:03
    @Qs-F Qs-F requested a review from locona May 11, 2024 08:03
    Copy link
    Contributor

    @locona locona left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    MUI剥がし: Button
    2 participants