🧹 Clean up CMS javascript assets #3773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josemigallas
commented
May 2, 2024
josemigallas
commented
- Reduce/Remove dependency from jQuery to remove technical debt
- Remove mysterious functions from global scope
- Reduce boilerplate
- Remove old, broken and/or unused files and scripts
- Remove duplicated files and code
- Put files where they belong (dev portal ones under lib/developer_portal)
josemigallas
force-pushed
the
javascript_cms
branch
5 times, most recently
from
d4d343f
to
50a7d89
Compare
josemigallas
force-pushed
the
javascript_cms
branch
3 times, most recently
from
c38d1ec
to
98f2faf
Compare
josemigallas
force-pushed
the
javascript_cms
branch
from
98f2faf
to
c8b1cde
Compare
jlledom
reviewed
May 22, 2024
There was a problem hiding this comment.
I don't feel very capable of reviewing this but I checked out the branch locally and it seems to work fine for me.
@josemigallas how are you sure these are not breaking changes?
There was a problem hiding this comment.
You should remove this warning:
porta/features/old/cms/versioning.feature
Line 12 in de95283
| <%= javascript_include_tag 'codemirror/modes/liquid' %> | ||
|
|
||
| <%= javascript_tag do %> | ||
| <% timeout = (Rails.env.development? or Rails.env.test?) ? 10000 : 3000 -%> |
There was a problem hiding this comment.
Who knows, I decided to let it be (it comes from https://github.com/3scale/porta/blob/1ca3cb2e8f364a4e7f0f17c1bf4263ae36de21c4/app/views/provider/admin/cms/_includes.html.erb)
|
Super hard to review this, as I don't understand some code well enough. But it seems that the features the changes affect work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.