Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREESCALE-10880: Bump rails from 6.0.6.1 to 6.1.7.7 #3705

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

THREESCALE-10880: Bump rails from 6.0.6.1 to 6.1.7.7 #3705

wants to merge 15 commits into from

Commits on May 28, 2024

  1. Upgrade rails to 6.1 and other dependencies

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4862281 View commit details
    Browse the repository at this point in the history

  2. Adapt database configuration to ActiveRecord 6.1

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    aef3121 View commit details
    Browse the repository at this point in the history

  3. Update Oracle permissions using the new interface

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    24479df View commit details
    Browse the repository at this point in the history

  4. Simplify config_for and always use symbols for keys 

    This is caused by the following change:
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#rails-application-config-for-return-value-no-longer-supports-access-with-string-keys

Now all configs coming from YAML files are deep-symbolized by default
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d0c5850 View commit details
    Browse the repository at this point in the history

  5. Update Rails default files and configs with 'rails app:update' task

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    31fc647 View commit details
    Browse the repository at this point in the history

  6. Remove monkey patches that are not needed after Rails 6.1 upgrade

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    993e43a View commit details
    Browse the repository at this point in the history

  7. Fix issues related to errors API deprecation 

    See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activemodel-error-class
and
rails/rails#32313
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9636b19 View commit details
    Browse the repository at this point in the history

  8. Update DB schemas after Rails 6.1. upgrade

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    11b566c View commit details
    Browse the repository at this point in the history

  9. Fix 'Cache-Control' header after Rails 6.1 upgrade 

    Rails 6.1 cuts out the `no-cache` value from the header, due to this normalization [1], see commit [2].

According to the docs [3] `no-store` is "stronger" than `no-cache`, which indeed makes `no-cache` redundant
in presence of `no-store`, so I changed the headers we set in `ApplicationController#disable_client_cache`.

[1] https://github.com/rails/rails/blob/v6.1.7.7/actionpack/lib/action_dispatch/http/cache.rb#L185-L222

[2] rails/rails@e06f7b3#diff-d77084e8407ab72b3068ae0268553de59c351ba520adc9c248e24e887b3fd5bf

[3] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d6a8a51 View commit details
    Browse the repository at this point in the history

  10. Fix different issues after Rails 6.1 upgrade

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    872aab4 View commit details
    Browse the repository at this point in the history

  11. Prevent exceptions when deserializing EventStore::Event on transactio… 

    …n rollback
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    8c068a3 View commit details
    Browse the repository at this point in the history

  12. Fix Oracle issues by disabling 'use_old_oracle_visitor' 

    Old Arel visitor was causing issues with ROWNUM, so we removed it.
The new Arel visitor forms some queries that incude subqueries with
ORDER BY, which throws an error in Oracle: ORA-00907: missing right parenthesis
So, order has been removed from some scopes to avoid this issue.
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    384e2ba View commit details
    Browse the repository at this point in the history

  13. Fix monthly_revenue_query for PostgreSQL 

    This got broken in Rails 6.1, specifically for PostgreSQL, reported in
rails/rails#41651
It was fixed by rails/rails@587522e
but I believe that the fix in this commit will work both with or without
the Rails fix, so we don't need to worry about it when we upgrade again
(it's just that the .cast method will be called more times after all
column types are back again in the `column_types` hash in Rails 7, which was the
behavior until Rails 6.1)
    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4f47e9a View commit details
    Browse the repository at this point in the history

  14. Avoid return within a transaction

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9df429f View commit details
    Browse the repository at this point in the history

  15. Fix small issue in cucumber steps

    @mayorova
    mayorova committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a8c8310 View commit details
    Browse the repository at this point in the history