Replace scss_lint with stylelint #5641
Conversation
| sass (3.7.4) | ||
| sass-listen (~> 4.0.0) | ||
| sass-listen (4.0.0) | ||
| rb-fsevent (~> 0.9, >= 0.9.4) | ||
| rb-inotify (~> 0.9, >= 0.9.7) |
There was a problem hiding this comment.
YESSSSS next up remove sassc!!! 🔥 🔥 🔥
There was a problem hiding this comment.
I don't know if my webpack skills are sufficient for the sprocket replacement journey, but I agree 😛
There was a problem hiding this comment.
Also guessing we'll want to do the webpack 4 -> webpack 5 thing at some point too
There was a problem hiding this comment.
Also guessing we'll want to do the webpack 4 -> webpack 5 thing at some point too
Still waiting on Webpacker v6 😩 (rc6 as of a few weeks ago)
There was a problem hiding this comment.
Right now this doesn't seem to enforce much at all in terms of styling. For example, the following is perfectly valid:
.language-desktop-button{
background-color:transparent; }The other configuration you mentioned seems interesting as enforcing some common conventions. Did you try it out?
The 18F Engineering Guide codifies some of the styling we might want to aim for if we'd care to build out our own configuration.
I'm also fine to just get this in to unblock Ruby 3 and sort out the specific styling rules later / as we encounter them.
mitchellhenke
force-pushed
the
mitchellhenke/stylelint
branch
from
0ef0b34
to
8e6e48f
Compare
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/stylelint
branch
from
2082f1b
to
b389e6e
Compare
scss_lintdepends onruby-sass, which reached it's end-of-life in March of 2019, so we should drop it.stylelintseemed to be the consensus replacement in past discussions and more generally in this space.I started with the rule set in stylelint-config-recommended-scss as it was the least restrictive. stylelint-config-standard-scss is the other option should we want to include some of the rules there.
I am not confident that we have covered all of the old rules that
scss_linthad though.