-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Permettre de rattacher un profil cible à une certification complementaire (PIX-12404) #8945
[FEATURE] Permettre de rattacher un profil cible à une certification complementaire (PIX-12404) #8945
Conversation
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
ab053b5
to
160237d
Compare
160237d
to
7e368c2
Compare
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
25896ef
to
0af419a
Compare
@@ -17,7 +17,7 @@ const attachTargetProfile = async function (request, h, dependencies = { complem | |||
complementaryCertificationBadgesToAttachDTO: complementaryCertificationBadges, | |||
}); | |||
|
|||
if (notifyOrganizations) { | |||
if (!!targetProfileId && notifyOrganizations) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas obligé de caster en boolean avec !!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!! cast en Boolean, mais tu as raison ca equivaut à Boolean(targetProfileId)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha non je voulais dire on peut faire ça direct ?
if (!!targetProfileId && notifyOrganizations) { | |
if (targetProfileId && notifyOrganizations) { |
}); | ||
context('when there is no target profile to remove', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petit saut de ligne pour aérer 😬 (fais moi savoir si ce genre de retour "relou" je peux le traiter moi même pour gagner du temps). Peut être le mieux serait d'avoir une règle eslint pour gérer ça automatiquement 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le top serait de faire la suggestion, comme ca ont peut les prendre en compte via github (et un petit rebase)
}); | |
context('when there is no target profile to remove', function () { | |
}); | |
context('when there is no target profile to remove', function () { |
this.route('attach-target-profile', { path: '/attach-target-profile/:target_profile_id' }); | ||
this.route('attach-target-profile', function () { | ||
this.route('update', { path: '/:target_profile_id' }); | ||
this.route('new'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si tu sais comment faire je suis preneur!
@@ -103,6 +103,7 @@ export default class AttachTargetProfileController extends Controller { | |||
`Profil cible rattaché à la certification ${complementaryCertification.label} mis à jour avec succès !`, | |||
); | |||
} catch (error) { | |||
console.error({ error }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un oubli ?
console.error({ error }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Etonnant que ca pete pas le build. Apres je trouve ca quand meme cool d'avoir les logs quand ca pete (mais bon c'est pas necessaire en prod)
0af419a
to
6da3845
Compare
🦄 Problème
On peut modifier le profil cible lié à une certification complémentaire mais ce n'est pas possible de faire l'ajout via l'interface
🤖 Proposition
Permettre de lier un profil cible à une nouvelle certification complementaire
🌈 Remarques
💯 Pour tester
INSERT INTO "complementary-certifications" ("label", "minimumReproducibilityRate", "key", "hasComplementaryReferential", "hasExternalJury", "certificationExtraTime", "minimumReproducibilityRateLowerLevel") values ('Pix+ Santé', 70, 'PRO_SANTE', true, false, 45, 60);