Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Supprimer les constantes spécifiques des fournisseurs d'identité OIDC (PIX-12428) #8913

Merged
merged 11 commits into from
May 23, 2024
Merged

[TECH] Supprimer les constantes spécifiques des fournisseurs d'identité OIDC (PIX-12428) #8913

merged 11 commits into from
May 23, 2024

Conversation

EmmanuelleBonnemay
Copy link
Contributor

@EmmanuelleBonnemay EmmanuelleBonnemay commented May 14, 2024 •
edited

🦄 Problème

Les constantes liées à chaque fournisseur d'identité ne sont plus utiles avec l'avancée du processus d'industrialisation du SSO

🤖 Proposition

Retirer ces constantes.

🌈 Remarques

Nous ne retirons pas les constantes de France Travail.

💯 Pour tester

Faire des tests de non régression (connexion, déconnexion, réconciliation) sur tous les fournisseurs d'identité.
Vérifier aussi le bon fonctionnement de la suppression et du déplacement des méthodes d'authentification par SSO depuis Pix Admin.

@EmmanuelleBonnemay EmmanuelleBonnemay self-assigned this May 14, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch 3 times, most recently from d10fc2a to fbe40bb Compare May 15, 2024 07:51
@EmmanuelleBonnemay EmmanuelleBonnemay requested a review from a team as a code owner May 15, 2024 07:51
igorissen
igorissen reviewed May 15, 2024
View reviewed changes
api/lib/application/users/index.js Show resolved Hide resolved
api/lib/application/users/index.js Outdated Show resolved Hide resolved
api/db/seeds/data/team-acces/build-users.js Show resolved Hide resolved
api/lib/domain/constants/oidc-identity-providers.js Outdated Show resolved Hide resolved
api/scripts/team-acces/update-fwb-authentication-complements.js Outdated Show resolved Hide resolved
api/tests/unit/application/users/index_test.js Outdated Show resolved Hide resolved
api/tests/unit/application/users/index_test.js Show resolved Hide resolved
api/tests/unit/application/users/index_test.js Outdated Show resolved Hide resolved
api/tests/unit/application/users/index_test.js Outdated Show resolved Hide resolved
api/src/shared/infrastructure/repositories/user-repository.js Outdated Show resolved Hide resolved
@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch 5 times, most recently from 05145b3 to ac3e2ed Compare May 15, 2024 22:33
@igorissen igorissen changed the title [REFACTOR] Supprimer les constantes spécifiques des fournisseurs d'identité OIDC (PIX-12428) [TECH] Supprimer les constantes spécifiques des fournisseurs d'identité OIDC (PIX-12428) May 16, 2024
@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch from ac3e2ed to 0c797e2 Compare May 16, 2024 09:10
igorissen
igorissen approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@igorissen igorissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé sur Chrome Version 124.0.6367.208 (Official Build) (x86_64)

@lego-technix lego-technix self-requested a review May 21, 2024 07:22
@lego-technix lego-technix force-pushed the pix-12428-delete-specific-sso-constants branch from 0c797e2 to a95b789 Compare May 21, 2024 14:42
@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch 3 times, most recently from 457c60f to c1ed1e7 Compare May 22, 2024 09:07
@lego-technix lego-technix force-pushed the pix-12428-delete-specific-sso-constants branch from 2562a2d to 31a434f Compare May 22, 2024 09:31
@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch 2 times, most recently from 7983d3c to 082d8ee Compare May 22, 2024 12:16
lego-technix
lego-technix approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé fonctionnellement avec succès avec Firefox

@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12428-delete-specific-sso-constants branch from 69538fa to d31e334 Compare May 23, 2024 06:40
lego-technix
lego-technix approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé fonctionnellement avec succès avec Firefox à nouveau

EmmanuelleBonnemay and others added 11 commits May 23, 2024 12:07
@EmmanuelleBonnemay
refactor(api): change return statements and order of asserts in index…
13c3a20 
… tests
@EmmanuelleBonnemay
refactor(api): remove specific identity provider payload validation
02ce707
@lego-technix @igorissen
@er-lim @EmmanuelleBonnemay
refactor(admin): remove useless identity-provider in payload
eca9ad3 
Co-authored-by: Ismael Gorissen <ismael.gorissen@gmail.com>
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Eric Lim <eric.lim@pix.fr>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@EmmanuelleBonnemay
refactor(api): delete now untestable specific type of OIDC SSO
7bf2559
@EmmanuelleBonnemay
refactor(api): replace specific constants by a generic oidc provider …
918ae9f 
…code
@lego-technix @igorissen
@er-lim @EmmanuelleBonnemay
refactor(api): remove OIDC SSO condition
41a555e 
in retrieval of AuthenticationMethod from UserRepository

Co-authored-by: Ismael Gorissen <ismael.gorissen@gmail.com>
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Eric Lim <eric.lim@pix.fr>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@lego-technix @igorissen
@er-lim @EmmanuelleBonnemay
refactor(api): delete now unused OIDC SSO constants
29653a8 
Co-authored-by: Ismael Gorissen <ismael.gorissen@gmail.com>
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Eric Lim <eric.lim@pix.fr>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@lego-technix @EmmanuelleBonnemay
refactor(api): remove now unused scripts
2cdf886 
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@EmmanuelleBonnemay @lego-technix
refactor(api): delete specific SSO build users
c191c6a 
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
@EmmanuelleBonnemay
refactor(api): delete specific OIDC SSO test
1b31fdf
@EmmanuelleBonnemay
refactor(api): replace 'type' variable name by more explicit 'authent…
68d19f0 
…icationMethodType'
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12428-delete-specific-sso-constants branch from eec3f5f to 68d19f0 Compare May 23, 2024 12:07
@pix-service-auto-merge pix-service-auto-merge merged commit 66c1d5f into dev May 23, 2024
5 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-12428-delete-specific-sso-constants branch May 23, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorissen igorissen igorissen approved these changes

@er-lim er-lim er-lim left review comments

@lego-technix lego-technix lego-technix approved these changes

Assignees

@EmmanuelleBonnemay EmmanuelleBonnemay

Labels
🚀 Ready to Merge team-acces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@EmmanuelleBonnemay @pix-bot-github @igorissen @er-lim @lego-technix @pix-service-auto-merge