[FEATURE] Dégradation du score d'une certification non terminée (PIX-12315). #8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
1f4db52
to
4c9d6e0
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
from
6a3354a
to
188eae5
Compare
matthieu-octo
force-pushed
the
pix-12315-downgrade-score
branch
3 times, most recently
from
b4759ea
to
ace700a
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
from
ace700a
to
3288a3f
Compare
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
3288a3f
to
c838ace
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
2 times, most recently
from
89e45c6
to
6610da4
Compare
matthieu-octo
force-pushed
the
pix-12315-downgrade-score
branch
2 times, most recently
from
685a5e8
to
8f81c43
Compare
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
8f81c43
to
65edacf
Compare
matthieu-octo
force-pushed
the
pix-12315-downgrade-score
branch
from
65edacf
to
1dfd9e4
Compare
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
1dfd9e4
to
4da1351
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
4 times, most recently
from
f6a4a07
to
aa1ffe2
Compare
matthieu-octo
force-pushed
the
pix-12315-downgrade-score
branch
2 times, most recently
from
ba37b18
to
a807cd3
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
3 times, most recently
from
faa6b78
to
e123f33
Compare
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
2 times, most recently
from
d9325d8
to
43ddecc
Compare
alexandrecoin
changed the title
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
43ddecc
to
dce33b4
Compare
alexandrecoin
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
aceol
approved these changes
May 21, 2024
| describe('when the candidate has not answered all the questions', function () { | ||
| it('should downgrade the pix score', async function () { | ||
| // given | ||
| const learningContent = [ |
There was a problem hiding this comment.
Il semble pertinent de clarifier ce test:
- pourquoi est-ce necessaire d'avoir ce learning content precis? (cela peut etre clarifier en l'extractant dans une methode nommé)
- Pourquoi parle t'on de finished/unfished mais puis de completed/downgraded?
- Que veut dire le closeTo ici? Est-ce que le test reste OK si les resultats sont identique? (donc pas de degradation)
There was a problem hiding this comment.
On a modifié le fichier en conséquence :)
api/tests/shared/integration/infrastructure/repositories/challenge-repository_test.js
Outdated
Show resolved
Hide resolved
api/tests/shared/unit/infrastructure/datasources/learning-content/challenge-datasource_test.js
Outdated
Show resolved
Hide resolved
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
2 times, most recently
from
83da0b1
to
c22366a
Compare
P-Jeremy
force-pushed
the
pix-12315-downgrade-score
branch
from
c22366a
to
7aeae3c
Compare
P-Jeremy
approved these changes
May 23, 2024
alexandrecoin
added
Tech Review OK
Func Review OK
alexandrecoin
force-pushed
the
pix-12315-downgrade-score
branch
from
7aeae3c
to
183f2b0
Compare
pix-service-auto-merge
force-pushed
the
pix-12315-downgrade-score
branch
from
183f2b0
to
b6289a1
Compare
pix-service-auto-merge
force-pushed
the
pix-12315-downgrade-score
branch
from
b6289a1
to
0ad7ddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Pour connaitre l'origine du problème, voir la section dédiée sur le ticket : PIX-12315
🤖 Proposition
Pour connaitre la proposition de résolution voir la section dédiée sur le ticket : PIX-12315
🌈 Remarques
💯 Pour tester
Pour savoir comment tester cette fonctionnalité, voir la section dédiée sur le ticket : PIX-12315