[BREAKING] Utilisation de yield nommés dans le PixAppLayout (pix-15665) #792
+282
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr792.review.pix.fr |
xav-car
approved these changes
Dec 13, 2024
pix-service-auto-merge
deleted the
pix-15665/add-footer-to-pix-app-layout
branch
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [52.0.0](v51.6.1...v52.0.0) (2024-12-13) ### 💥 BREAKING CHANGE - [#792](#792) Utilisation de yield nommés dans le PixAppLayout (pix-15665)
|
🎉 This PR is included in version 52.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 BREAKING_CHANGES
Le Composant utilise désormais 3 yield nommés plutot qu'un seul yield
<:navigation><:main><:footer>🎄 Problème
Le positionnement du footer se fait actuellement dans les applications est n'est pas toujours homogène.
🎁 Proposition
Afin d'améliorer l'homogénéité du design de nos applications, le positionnement du footer est géré par le composant AppLayout
🌟 Remarques
On a fait le choix de ne pas mettre de balise pour le main et le
footerpour permettre de pouvoir rajouter une classe si besoin.On profite de la PR pour rajouter une règle pour que le
AppLayoutprenne toute la hauteur disponible si le contenu tient dans le viewport.🎅 Pour tester
Afficher la story du composant AppLayout