Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort inbox rows by time. #26962

Closed
amanagr opened this issue Oct 2, 2023 · 0 comments · Fixed by #27059
Closed

Sort inbox rows by time. #26962

amanagr opened this issue Oct 2, 2023 · 0 comments · Fixed by #27059
Labels
area: inbox view Issues related to the inbox view blocked priority: high

Comments

@amanagr
Copy link
Member

amanagr commented Oct 2, 2023

Blocked on handlebars-lang/handlebars.js#1996 (already merged) being released. Since we need Maps to maintain insertion order. Plain objects are not perfect for this.

https://github.com/amanagr/zulip/tree/inbox_sort_1 and https://github.com/amanagr/zulip/tree/inbox_sort_by_time

have 90% of the work needed for this.
@amanagr amanagr added priority: high blocked area: inbox view Issues related to the inbox view labels Oct 2, 2023
@amanagr amanagr mentioned this issue Oct 2, 2023
Closed
amanagr added a commit to amanagr/zulip that referenced this issue Oct 5, 2023
@amanagr
inbox: Render rows in sorted order.
d26c820 
Fixes zulip#26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
@amanagr amanagr mentioned this issue Oct 5, 2023
Merged
amanagr added a commit to amanagr/zulip that referenced this issue Oct 5, 2023
@amanagr
inbox: Render rows in sorted order.
d5ba092 
Fixes zulip#26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
timabbott pushed a commit that referenced this issue Oct 5, 2023
@amanagr @timabbott
inbox: Render rows in sorted order.
f2a00c7 
Fixes #26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
ToBadForYou pushed a commit to ToBadForYou/zulip that referenced this issue Oct 7, 2023
@amanagr @ToBadForYou
inbox: Render rows in sorted order.
ecf48bf 
Fixes zulip#26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
macieksarnowicz pushed a commit to macieksarnowicz/zulip that referenced this issue Oct 16, 2023
@amanagr @macieksarnowicz
inbox: Render rows in sorted order.
1e173d8 
Fixes zulip#26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
emmawitt pushed a commit to emmawitt/zulip that referenced this issue Nov 7, 2023
@amanagr
inbox: Render rows in sorted order.
069da69 
Fixes zulip#26962

We sort topic and dm data by latest_msg_id and render them.

For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: inbox view Issues related to the inbox view blocked priority: high
Projects
No open projects
Zulip Server 8.0 priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inbox sort by rows by latest msg id. amanagr/zulip
1 participant
@amanagr