Remove legacy class setters #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuputah
force-pushed
the
remove-legacy-class-setters
branch
from
b862a6c
to
67be746
Compare
Closed
wuputah
force-pushed
the
remove-legacy-class-setters
branch
from
67be746
to
eaba89e
Compare
orenyk
added a commit
to orenyk/suspenders
that referenced
this pull request
Jul 5, 2018
Resolves thoughtbot#918 Rack::Timeout v0.5.0 removed legacy setter methods used for configuration (zombocom/rack-timeout#125) such that the configuration added by Suspenders causes a NoMethodError when initializing Rails in the production environment (e.g. during Heroku deployment). This PR switches to using environment variable-based configuration of Rack::Timeout, matching the recommendations in the README.
composerinteralia
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Jul 21, 2018
Resolves #918 Rack::Timeout v0.5.0 removed legacy setter methods used for configuration (zombocom/rack-timeout#125) such that the configuration added by Suspenders causes a NoMethodError when initializing Rails in the production environment (e.g. during Heroku deployment). This PR switches to using environment variable-based configuration of Rack::Timeout, matching the recommendations in the README.
Marri
added a commit
to glowfic-constellation/glowfic
that referenced
this pull request
Oct 22, 2018
…t as an ENV variable and not with a class setter in an initializer file.
Marri
added a commit
to glowfic-constellation/glowfic
that referenced
this pull request
Oct 22, 2018
…t as an ENV variable and not with a class setter in an initializer file.
Web-Go-To
added a commit
to Web-Go-To/rails_suspenders
that referenced
this pull request
Mar 23, 2023
Resolves #918 Rack::Timeout v0.5.0 removed legacy setter methods used for configuration (zombocom/rack-timeout#125) such that the configuration added by Suspenders causes a NoMethodError when initializing Rails in the production environment (e.g. during Heroku deployment). This PR switches to using environment variable-based configuration of Rack::Timeout, matching the recommendations in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated/legacy class setters
resolves #119, resolves #117, resolves #118