fix: wasm build failure due to a missing use statement #313
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to zip-rs#312 (comment) - Added `File` to use statement. Found additional error (E0599) at line 463. - Added `?` operator. (`use the ? operator to extract `File` value, propagating a `Result::Err` value to caller`)
Pr0methean
previously approved these changes
Mar 17, 2025
Pr0methean
changed the title
File struct in read.rs. Fix for Issue 312Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #312 (comment)
Fileto use statement.Found additional error (E0599) at line 463.
?operator afteroutput. (use the ? operator to extractFilevalue, propagating aResult::Errvalue to caller)Replicated user's original test. Tested with Rust 1.85.0 on Windows 10 22H2 19045.5608.
cargo check --target wasm32-unknown-unknown --no-default-features.Besides some clippy messages, no other errors show up.