Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proguard rules for downstream consumption #152

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

madisp
Copy link
Contributor

@madisp madisp commented Mar 23, 2023

We use R8 to minify one of our CLI binaries and got bit by it as R8 decided to remove the ctor from the AsiExtraField class, resulting in the following crash:

Caused by: java.lang.RuntimeException: class S0.a is not a concrete class
	at S0.b.<clinit>(SourceFile:14)

This commit adds Proguard rules to the library jar so downstream minifier tools can pick them up automatically.

@toomasr toomasr merged commit 3a5c23d into zeroturnaround:master Mar 30, 2023
@madisp madisp deleted the madisp/add-proguard-rules branch March 30, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants