Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【rich function】 #3

Merged
merged 4 commits into from
Aug 10, 2020
Merged

【rich function】 #3

merged 4 commits into from
Aug 10, 2020
+110 −34

Conversation

xiaowei520
Copy link
Contributor

I want append CustomVersionCompare

@kevwan
Copy link
Contributor

kevwan commented Aug 9, 2020

@xiaowei520 你好，是不是在CompareVersions里面增加一下替换V, v等的代码就好了？那个CustomCompare的有啥用途呢？谢谢！

@xiaowei520
Copy link
Contributor Author

@xiaowei520 你好，是不是在CompareVersions里面增加一下替换V, v等的代码就好了？那个CustomCompare的有啥用途呢？谢谢！

版本判断,统一由custom判断收敛更自由一些。因为在日常开发中,这种场景用途较多,比如apollo流量控制 来判断不同版本执行不同的case

@kevwan
Copy link
Contributor

kevwan commented Aug 9, 2020

@xiaowei520 你好，是不是在CompareVersions里面增加一下替换V, v等的代码就好了？那个CustomCompare的有啥用途呢？谢谢！

版本判断,统一由custom判断收敛更自由一些。因为在日常开发中,这种场景用途较多,比如apollo流量控制 来判断不同版本执行不同的case

有道理，那就直接把CompareVersions改成这个就好了，统一使用，我觉得做同一件事不应该提供多种方式。

BTW: 可以加我微信kevwan，我拉你进项目交流群

kevwan
kevwan reviewed Aug 9, 2020
View reviewed changes
@kevwan kevwan merged commit 4c9b481 into zeromicro:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiaowei520 @kevwan