#412: total_commits_pushed

Author: yegor256

judges/quantity-of-deliverables/quantity-of-deliverables.rb

@@ -22,10 +22,8 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-require 'fbe/fb'
-require 'fbe/octo'
 require 'fbe/overwrite'
-require 'fbe/unmask_repos'
+require 'fbe/octo'
 require 'fbe/regularly'
 
 start = Time.now
@@ -44,18 +42,4 @@
     require_relative rb
     send(n, f).each { |k, v| f = Fbe.overwrite(f, k.to_s, v) }
   end
-
-  # Number of commits pushed and their hits-of-code:
-  commits = 0
-  hoc = 0
-  Fbe.unmask_repos.each do |repo|
-    next if Fbe.octo.repository(repo)[:size].zero?
-
-    Fbe.octo.commits_since(repo, f.since).each do |json|
-      commits += 1
-      hoc += Fbe.octo.commit(repo, json[:sha])[:stats][:total]
-    end
-  end
-  f.total_commits_pushed = commits
-  f.total_hoc_committed = hoc
 end

judges/quantity-of-deliverables/total_commits_pushed.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+# MIT License
+#
+# Copyright (c) 2024 Zerocracy
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+require 'fbe/octo'
+require 'fbe/unmask_repos'
+
+# Number of commits pushed and their hits-of-code:
+#
+# This function is called from the "quantity-of-deliverables.rb".
+#
+# @param [Factbase::Fact] fact The fact just under processing
+# @return [Hash] Map with keys as fact attributes and values as integers
+def total_commits_pushed(fact)
+  commits = 0
+  hoc = 0
+  Fbe.unmask_repos.each do |repo|
+    next if Fbe.octo.repository(repo)[:size].zero?
+    Fbe.octo.commits_since(repo, fact.since).each do |json|
+      commits += 1
+      hoc += Fbe.octo.commit(repo, json[:sha])[:stats][:total]
+    end
+  end
+  {
+    total_commits_pushed: commits,
+    total_hoc_committed: hoc
+  }
+end

test/judges/test-quantity-of-deliverables.rb

@@ -28,6 +28,7 @@
 require 'minitest/autorun'
 require 'webmock/minitest'
 require 'judges/options'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -37,58 +38,48 @@ class TestQuantityOfDeliverables < Minitest::Test
   def test_counts_commits
     WebMock.disable_net_connect!
     stub_github('https://api.github.com/rate_limit', body: {})
-    stub_request(:get, 'https://api.github.com/user/42').to_return(
-      body: { id: 42, login: 'torvalds' }.to_json, headers: {
-        'content-type': 'application/json'
-      }
+    stub_github(
+      'https://api.github.com/user/42',
+      body: { id: 42, login: 'torvalds' }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo').to_return(
-      body: { id: 42, full_name: 'foo/foo', open_issues: 0, size: 10 }.to_json, headers: {
-        'content-type': 'application/json'
-      }
+    stub_github(
+      'https://api.github.com/repos/foo/foo',
+      body: { id: 42, full_name: 'foo/foo', open_issues: 0, size: 10 }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/commits?per_page=100&since=2024-07-15T21:00:00%2B00:00').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/commits?per_page=100&since=2024-07-15T21:00:00%2B00:00',
       body: [
         {
           sha: 'bcb3cd5c2a6f3daebe1a2ab16a195a0bf2609943'
         },
         {
           sha: '0d705c564abc9e5088f00310c42b82bc9f192a3d'
         }
-      ].to_json,
-      headers: {
-        'content-type': 'application/json'
-      }
+      ]
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/commits/bcb3cd5c2a6f3daebe1a2ab16a195a0bf2609943').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/commits/bcb3cd5c2a6f3daebe1a2ab16a195a0bf2609943',
       body: {
         stats: {
           total: 10
         }
-      }.to_json,
-      headers: {
-        'content-type': 'application/json'
       }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/commits/0d705c564abc9e5088f00310c42b82bc9f192a3d').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/commits/0d705c564abc9e5088f00310c42b82bc9f192a3d',
       body: {
         stats: {
           total: 10
         }
-      }.to_json,
-      headers: {
-        'content-type': 'application/json'
       }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/issues?per_page=100&since=%3E2024-07-15').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/issues?per_page=100&since=%3E2024-07-15',
       body: [
         {
           pull_request: {}
         }
-      ].to_json,
-      headers: {
-        'content-type': 'application/json'
-      }
+      ]
     )
     stub_github(
       'https://api.github.com/repos/foo/foo/releases?per_page=100',
@@ -113,32 +104,26 @@ def test_counts_commits
   def test_processes_empty_repository
     WebMock.disable_net_connect!
     stub_github('https://api.github.com/rate_limit', body: {})
-    stub_request(:get, 'https://api.github.com/user/42').to_return(
-      body: { id: 42, login: 'torvalds' }.to_json, headers: {
-        'content-type': 'application/json'
-      }
+    stub_github(
+      'https://api.github.com/user/42',
+      body: { id: 42, login: 'torvalds' }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo').to_return(
-      body: { id: 42, full_name: 'foo/foo', open_issues: 0, size: 0 }.to_json, headers: {
-        'content-type': 'application/json'
-      }
+    stub_github(
+      'https://api.github.com/repos/foo/foo',
+      body: { id: 42, full_name: 'foo/foo', open_issues: 0, size: 0 }
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/commits?per_page=100&since=2024-07-15T21:00:00%2B00:00').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/commits?per_page=100&since=2024-07-15T21:00:00%2B00:00',
       status: 409,
-      body: [].to_json,
-      headers: {
-        'content-type': 'application/json'
-      }
+      body: []
     )
-    stub_request(:get, 'https://api.github.com/repos/foo/foo/issues?per_page=100&since=%3E2024-07-15').to_return(
+    stub_github(
+      'https://api.github.com/repos/foo/foo/issues?per_page=100&since=%3E2024-07-15',
       body: [
         {
           pull_request: {}
         }
-      ].to_json,
-      headers: {
-        'content-type': 'application/json'
-      }
+      ]
     )
     stub_github(
       'https://api.github.com/repos/foo/foo/releases?per_page=100',