#492 factbase up

Author: yegor256

Gemfile

@@ -6,9 +6,9 @@
 source 'https://rubygems.org'
 
 gem 'decoor', '>0'
-gem 'factbase', '>=0.8.0'
-gem 'fbe', '>=0.0.86'
-gem 'judges', '>=0.36.2'
+gem 'factbase', '>=0.9.1'
+gem 'fbe', '>=0.2.1'
+gem 'judges', '>=0.36.3'
 gem 'minitest', '5.25.4', require: false
 gem 'minitest-reporters', '1.7.1', require: false
 gem 'others', '>0'

Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.1)
+    activesupport (8.0.2)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -48,7 +48,7 @@ GEM
       tago (> 0)
     ethon (0.16.0)
       ffi (>= 1.15.0)
-    factbase (0.8.0)
+    factbase (0.9.1)
       backtrace (>= 0.4.0)
       decoor (>= 0.0.1)
       json (~> 2.7)
@@ -69,11 +69,11 @@ GEM
       net-http (>= 0.5.0)
     faraday-retry (2.2.1)
       faraday (~> 2.0)
-    fbe (0.1.0)
+    fbe (0.2.1)
       backtrace (~> 0)
       baza.rb (~> 0)
       decoor (~> 0)
-      factbase (>= 0.7.4)
+      factbase (>= 0.9.1)
       faraday (~> 2)
       faraday-http-cache (~> 2)
       faraday-multipart (~> 1)
@@ -92,7 +92,7 @@ GEM
     fiber-storage (1.0.0)
     gli (2.22.2)
       ostruct
-    graphql (2.4.11)
+    graphql (2.4.13)
       base64
       fiber-storage
       logger
@@ -103,13 +103,13 @@ GEM
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     iri (0.10.0)
-    json (2.10.1)
-    judges (0.36.2)
+    json (2.10.2)
+    judges (0.36.3)
       backtrace (~> 0)
       baza.rb (~> 0)
       concurrent-ruby (~> 1.2)
       elapsed (~> 0)
-      factbase (>= 0.7.5)
+      factbase (>= 0.9.1)
       gli (~> 2.21)
       iri (~> 0)
       loog (~> 0)
@@ -226,9 +226,9 @@ PLATFORMS
 
 DEPENDENCIES
   decoor (> 0)
-  factbase (>= 0.8.0)
-  fbe (>= 0.0.86)
-  judges (>= 0.36.2)
+  factbase (>= 0.9.1)
+  fbe (>= 0.2.1)
+  judges (>= 0.36.3)
   minitest (= 5.25.4)
   minitest-reporters (= 1.7.1)
   others (> 0)

Rakefile

@@ -7,6 +7,8 @@ require 'rubygems'
 require 'rake'
 require 'rake/clean'
 
+ENV['RACK_RUN'] = 'true'
+
 task default: %i[clean test judges rubocop]
 
 require 'rake/testtask'

judges/github-events/github-events.rb

@@ -33,12 +33,13 @@ def self.fetch_tag(fact, repo)
       tag = Fbe.octo.release(
         "https://api.github.com/repos/#{repo}/releases/#{fact.release_id}"
       ).fetch(:tag_name, nil)
+      $loog.debug("The release ##{fact.release_id} has this tag: #{tag.inspect}")
     end
     tag
   end
 
   def self.fetch_contributors(fact, repo)
-    last = Fbe.fb.query("(and (eq repository #{fact.repository}) (eq what \"#{fact.what}\"))").each.last
+    last = Fbe.fb.query("(and (eq repository #{fact.repository}) (eq what \"#{fact.what}\"))").each.to_a.last
     tag = fetch_tag(last, repo)
     contributors = Set.new
     if tag
@@ -51,11 +52,12 @@ def self.fetch_contributors(fact, repo)
         contributors << contributor[:id]
       end
     end
+    $loog.debug("The repository ##{fact.repository} has #{contributors.count} contributors")
     contributors.to_a
   end
 
   def self.fetch_release_info(fact, repo)
-    last = Fbe.fb.query("(and (eq repository #{fact.repository}) (eq what \"#{fact.what}\"))").each.last
+    last = Fbe.fb.query("(and (eq repository #{fact.repository}) (eq what \"#{fact.what}\"))").each.to_a.last
     tag = fetch_tag(last, repo)
     tag ||= find_first_commit(repo)[:sha]
     info = {}
@@ -64,6 +66,7 @@ def self.fetch_release_info(fact, repo)
       info[:hoc] = json[:files].sum { |f| f[:changes] }
       info[:last_commit] = json[:commits].first[:sha]
     end
+    $loog.debug("The repository ##{fact.repository} has this: #{info.inspect}")
     info
   end
 
@@ -74,6 +77,7 @@ def self.find_first_commit(repo)
       commits = Fbe.octo.commits(repo, sha: last[:sha])
       last = commits.last
     end
+    $loog.debug("The repo ##{repo} has this last commit: #{last}")
     last
   end
 
@@ -172,6 +176,7 @@ def self.fill_up_event(fact, json)
         "A new Git push ##{json[:payload][:push_id]} has arrived to #{rname}, " \
         "made by #{Fbe.who(fact)} (default branch is '#{fact.default_branch}'), " \
         'not associated with any pull request.'
+      $loog.debug("New PushEvent ##{json[:payload][:push_id]} recorded")
 
     when 'PullRequestEvent'
       pl = json[:payload][:pull_request]
@@ -181,6 +186,7 @@ def self.fill_up_event(fact, json)
         fact.what = 'pull-was-opened'
         fact.branch = pl[:head][:ref]
         fact.details = "The pull request #{Fbe.issue(fact)} has been opened by #{Fbe.who(fact)}."
+        $loog.debug("New PR #{Fbe.issue(fact)} opened by #{Fbe.who(fact)}")
       when 'closed'
         fact.what = "pull-was-#{pl[:merged_at].nil? ? 'closed' : 'merged'}"
         fact.hoc = pl[:additions] + pl[:deletions]
@@ -191,6 +197,7 @@ def self.fill_up_event(fact, json)
           "The pull request #{Fbe.issue(fact)} " \
           "has been #{json[:payload][:action]} by #{Fbe.who(fact)}, " \
           "with #{fact.hoc} HoC and #{fact.comments} comments."
+        $loog.debug("PR #{Fbe.issue(fact)} closed by #{Fbe.who(fact)}")
       else
         skip_event(json)
       end
@@ -204,7 +211,7 @@ def self.fill_up_event(fact, json)
           '(eq what "pull-was-reviewed") ' \
           "(eq who #{fact.who}) " \
           "(eq issue #{json[:payload][:pull_request][:number]}))"
-        ).each.last
+        ).each.to_a.last
           skip_event(json)
         end
         skip_event(json) unless json[:payload][:review][:state] == 'approved'
@@ -220,6 +227,7 @@ def self.fill_up_event(fact, json)
           "The pull request #{Fbe.issue(fact)} " \
           "has been reviewed by #{Fbe.who(fact)} " \
           "with #{fact.hoc} HoC and #{fact.comments} comments."
+        $loog.debug("PR #{Fbe.issue(fact)} was reviewed by #{Fbe.who(fact)}")
       else
         skip_event(json)
       end
@@ -230,9 +238,11 @@ def self.fill_up_event(fact, json)
       when 'closed'
         fact.what = 'issue-was-closed'
         fact.details = "The issue #{Fbe.issue(fact)} has been closed by #{Fbe.who(fact)}."
+        $loog.debug("Issue #{Fbe.issue(fact)} closed by #{Fbe.who(fact)}")
       when 'opened'
         fact.what = 'issue-was-opened'
         fact.details = "The issue #{Fbe.issue(fact)} has been opened by #{Fbe.who(fact)}."
+        $loog.debug("Issue #{Fbe.issue(fact)} opened by #{Fbe.who(fact)}")
       else
         skip_event(json)
       end
@@ -249,6 +259,7 @@ def self.fill_up_event(fact, json)
         fact.details =
           "A new comment ##{json[:payload][:comment][:id]} has been posted " \
           "to #{Fbe.issue(fact)} by #{Fbe.who(fact)}."
+        $loog.debug("Issue comment posted to #{Fbe.issue(fact)} by #{Fbe.who(fact)}")
       end
       skip_event(json)
 
@@ -264,6 +275,7 @@ def self.fill_up_event(fact, json)
         fact.details =
           "A new release '#{json[:payload][:release][:name]}' has been published " \
           "in #{rname} by #{Fbe.who(fact)}."
+        $loog.debug("Release published by #{Fbe.who(fact)}")
       else
         skip_event(json)
       end
@@ -276,6 +288,7 @@ def self.fill_up_event(fact, json)
         fact.details =
           "A new tag '#{fact.tag}' has been created " \
           "in #{rname} by #{Fbe.who(fact)}."
+        $loog.debug("Tag #{fact.tag.inspect} created by #{Fbe.who(fact)}")
       else
         skip_event(json)
       end

judges/who-has-name/who-has-name.rb

@@ -38,7 +38,7 @@ def name_of(who)
     (eq what 'who-has-name')
     (eq where 'github')
     (exists who)
-    (lt when #{(Time.now - (5 * 24 * 60 * 60)).utc.iso8601}))"
+    (lt when (minus (to_time (env 'TODAY' '#{Time.now.utc.iso8601}')) '5 days')))"
 ).each.to_a.each do |f|
   Fbe.overwrite(f, 'name', name_of(f.who))
 end

test/judges/test-dimensions-of-terrain.rb

@@ -4,13 +4,12 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require 'fbe/octo'
 require 'fbe/github_graph'
-require 'loog'
+require 'fbe/octo'
 require 'json'
-require 'minitest/autorun'
-require 'webmock/minitest'
 require 'judges/options'
+require 'loog'
+require 'webmock/minitest'
 require_relative '../test__helper'
 
 # Test.

test/judges/test-find-all-issues.rb

@@ -4,11 +4,11 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require 'loog'
 require 'json'
-require 'minitest/autorun'
-require 'webmock/minitest'
 require 'judges/options'
+require 'loog'
+require 'webmock/minitest'
+require_relative '../test__helper'
 
 # Test.
 class TestFindAllIssues < Minitest::Test

test/judges/test-github-events.rb

@@ -6,11 +6,11 @@
 require 'factbase'
 require 'loog'
 require 'json'
-require 'minitest/autorun'
 require 'webmock/minitest'
 require 'judges/options'
 require 'fbe'
 require 'fbe/github_graph'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

test/judges/test-label-was-attached.rb

@@ -4,11 +4,11 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require 'loog'
 require 'json'
-require 'minitest/autorun'
-require 'webmock/minitest'
 require 'judges/options'
+require 'loog'
+require 'webmock/minitest'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

test/judges/test-quality-of-service.rb

@@ -6,9 +6,9 @@
 require 'factbase'
 require 'loog'
 require 'json'
-require 'minitest/autorun'
 require 'webmock/minitest'
 require 'judges/options'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

test/judges/test-quantity-of-deliverables.rb

@@ -4,11 +4,10 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require 'loog'
 require 'json'
-require 'minitest/autorun'
-require 'webmock/minitest'
 require 'judges/options'
+require 'loog'
+require 'webmock/minitest'
 require_relative '../test__helper'
 
 # Test.

test/judges/test-who-has-name.rb

@@ -4,8 +4,8 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require 'minitest/autorun'
 require 'webmock/minitest'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

test/test__helper.rb

@@ -23,7 +23,7 @@ def load_it(judge, fb, options = Judges::Options.new({ 'repositories' => 'foo/fo
     $local = {}
     $judge = judge
     $options = options
-    $loog = Loog::NULL
+    $loog = ENV['RACK_RUN'] ? Loog::NULL : Loog::VERBOSE
     $start = Time.now
     load(File.join(__dir__, "../judges/#{judge}/#{judge}.rb"))
   end