♻️ add back ts-compatible default export #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well... that seems like it would bloat the CommonJS module a lot. Maybe we should switch to ES modules and bundle with Rollup... |
|
Wow! Thanks for replying so hyperfast! I'll respond with the results of my investigation into using the beta version in that PR and close this one! |
Closed
|
Actually, the way I went about adding module.exports doesn't work because you can't mix ES imports with CJS exports. May have to merge this as 1.4.0 and release the other PR as 2.0.0 with module.exports deprecated. |
alexkrolick
added a commit
that referenced
this pull request
Jul 7, 2018
alexkrolick
added a commit
that referenced
this pull request
Jul 7, 2018
|
1.4.0-beta.5 worked! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
A few days ago, a change was introduced that broke TS default import expectations.
The import code specified in the readme isn't valid right now, I believe after this commit was added:
4c15c32
If doing
import * as ReactQuill from 'react-quill';the returned class won't have constructor or call methods, and it'll cease to work as advertised.I'm not sure if you're cool with this solution, but I've had to fork a work project with this solution to get things back to work. Let me know what you think!