chore: add num_comments_as_exitcode option
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this in #118 a bit. Having the exit-code be non-zero will cause the workflow to count as failed, even though it posted the comments successfully, which will notify the user. Using
continue-on-errorisn't ideal for this either, as it will hide errors in this action. On the other hand, I can understand the use-case for this.I'm adding the
num_comments_as_exitcodeinput/option, which, as the name suggests, controls whether the exit-code will be set to the number of comments or 0. It's enabled by default, so nothing should change.