fix: download artifacts as binary blobs and follow redirects #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for not testing properly in #115. The stuff still fails, because pygithub doesn't follow redirects and the artifact is a binary blob, not JSON (I tested it this time).
#113 noted that using
requestsisn't nice, so I'm usingurllib3.The
acceptheader might look weird, but the documentation recommends this even though we get a zip returned 馃檭.I've also noticed that this action still uses
actions/upload-action@v3(uses deprecated node version), so I updated it to v4.While testing, I noticed that the action fails even though it succeeded, because since #103, the action exits with the amount of comments. I'd like to open a PR (after this one) that adds an option to disable this.