Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust installation check in configure scripts #304

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

yutannihilation
Copy link
Owner

Fix #303

@yutannihilation
Copy link
Owner Author

Hmm, the nightly toolchain is too smart...

 error: this operation will panic at runtime
  --> /home/runner/work/savvy/savvy/R-package/src/rust/src/error_handling.rs:71:13
   |
71 |     let _ = x[1];
   |             ^^^^ index out of bounds: the length is 1 but the index is 1
   |
   = note: `#[deny(unconditional_panic)]` on by default

@yutannihilation yutannihilation merged commit 6f860a5 into main Oct 8, 2024
13 of 15 checks passed
@yutannihilation yutannihilation deleted the fix/configre-ret branch October 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure script doesn't check cargo properly
1 participant