Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs in element-newline #290

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix: bugs in element-newline #290

merged 3 commits into from
Feb 14, 2025

Conversation

yeonjuan
Copy link
Owner

fixes #289

@yeonjuan yeonjuan merged commit dc0b68e into main Feb 14, 2025
5 checks passed
@yeonjuan yeonjuan deleted the fixes#289 branch February 14, 2025 12:48
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.46%. Comparing base (8f7a4e8) to head (c4b11f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/eslint-plugin/lib/rules/element-newline.js 97.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   98.55%   98.46%   -0.09%     
==========================================
  Files          69       69              
  Lines        2008     2021      +13     
  Branches      553      558       +5     
==========================================
+ Hits         1979     1990      +11     
- Misses         29       31       +2     
Flag Coverage Δ
unittest 98.46% <97.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/rules/indent/indent.js 99.42% <ø> (ø)
packages/eslint-plugin/lib/rules/utils/node.js 95.58% <100.00%> (+0.13%) ⬆️
...ackages/eslint-plugin/lib/rules/element-newline.js 98.07% <97.43%> (-1.93%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

element-newline doesn't allow text on multiple lines
1 participant