Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyLineSeparatorCheck conflicts with EmptyLinesCheck #953

Closed
victornoel opened this issue Dec 2, 2018 · 18 comments
Closed

EmptyLineSeparatorCheck conflicts with EmptyLinesCheck #953

victornoel opened this issue Dec 2, 2018 · 18 comments
Assignees

Comments

@victornoel
Copy link

For example in Takes, in the following code at the following line: https://github.com/yegor256/takes/blob/3e53d1278d8a882343b877c5d7d2c04966491478/src/test/java/org/takes/http/BkBasicTest.java#L143

If don't separate the two methods with an empty line, you get:
[INFO] Checkstyle: src/test/java/org/takes/http/BkBasicTest.java[143]: 'METHOD_DEF' should be separated from previous statement. (EmptyLineSeparatorCheck)

If you add a line you get:
[INFO] Checkstyle: src/test/java/org/takes/http/BkBasicTest.java[143]: Empty line inside method (EmptyLinesCheck)

@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@krzyk
Copy link
Collaborator

krzyk commented Dec 2, 2018

@victornoel is this for 0.18.2?

@victornoel
Copy link
Author

@krzyk actually it is for both 0.18.2 and 0.17.6

@krzyk
Copy link
Collaborator

krzyk commented Dec 3, 2018

@0crat in

@krzyk
Copy link
Collaborator

krzyk commented Dec 3, 2018

@0crat assign me

@0crat 0crat added the scope label Dec 3, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

@0crat in (here)

@krzyk Job #953 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

@0crat assign me (here)

@krzyk The job #953 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

@krzyk
Copy link
Collaborator

krzyk commented Dec 4, 2018

@victornoel The issue is because there is a anonymous class inside anonymous class (which is not the best style, I think this should be prohibited in qulice) so for a fast workaround, convert one of those anonymous classes into an inner class

@krzyk
Copy link
Collaborator

krzyk commented Dec 5, 2018

@0crat help

@0crat
Copy link
Collaborator

0crat commented Dec 5, 2018

@0crat help (here)

@krzyk Can't understand "help", try one of these:

  • assign Assign a performer to this issue
  • boost Set a boost for the job
  • continue Remove a job's impediment
  • hello Just say hello
  • in Register this issue in scope (WBS)
  • out Close the order and remove this job from scope
  • pay Pay a user some extra cash
  • quality Review a task
  • resign Resign from this issue
  • status Check the status of the job
  • version Print current version of the bot
  • wait Register an impediment for a job

@krzyk
Copy link
Collaborator

krzyk commented Dec 5, 2018

@victornoel this should be fixed in 0.18.5, please close this issue

@victornoel
Copy link
Author

@krzyk excellent, thanks!

@0crat
Copy link
Collaborator

0crat commented Dec 5, 2018

Job was finished in 46 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Dec 5, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 5, 2018

The job #953 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 5, 2018

Order was finished: +35 point(s) just awarded to @krzyk/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants