Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require method JavaDoc for tests #848

Closed
yegor256 opened this issue Jun 2, 2017 · 24 comments
Closed

don't require method JavaDoc for tests #848

yegor256 opened this issue Jun 2, 2017 · 24 comments
Assignees

Comments

@yegor256
Copy link
Owner

yegor256 commented Jun 2, 2017

I believe method JavaDoc blocks are redundant. Instead, we should use reasons for assertThat(). See https://github.com/yegor256/cactoos/blob/master/src/test/java/org/cactoos/io/InputAsBytesTest.java

@0crat
Copy link
Collaborator

0crat commented Jun 2, 2017

@krzyk please, pay attention to this issue

@nqafield
Copy link

nqafield commented Jun 2, 2017

And then you've got to wonder if the test method names are also redundant. (Or the reasons.) :)

@krzyk
Copy link
Collaborator

krzyk commented Apr 29, 2018

@0crat in

@0crat 0crat added the scope label Apr 29, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 29, 2018

@0crat in (here)

@krzyk Job #848 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Apr 29, 2018

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Apr 29, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 4, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 9, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 14, 2018

@krzyk/z everybody who has role DEV are banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

@krzyk/z everybody who has role DEV are banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 24, 2018

@krzyk/z everybody who has role DEV is banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 30, 2018

@krzyk/z everybody who has role DEV is banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2018

@krzyk/z everybody who has role DEV is banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 9, 2018

@krzyk/z everybody who has role DEV is banned at #848; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator

krzyk commented Nov 30, 2018

@0crat assign me

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2018

@0crat assign me (here)

@krzyk The job #848 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

krzyk added a commit to krzyk/qulice that referenced this issue Nov 30, 2018
krzyk added a commit to krzyk/qulice that referenced this issue Nov 30, 2018
@krzyk
Copy link
Collaborator

krzyk commented Nov 30, 2018

@yegor256 please close this issue, it has been merged to master in #947 (and should be released on 0.18.3)

@krzyk
Copy link
Collaborator

krzyk commented Nov 30, 2018

@0crat waiting for review from issue author

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2018

@0crat waiting for review from issue author (here)

@krzyk The impediment for #848 was registered successfully by @krzyk/z

@krzyk
Copy link
Collaborator

krzyk commented Dec 4, 2018

@yegor256 ping, it has been released on 0.18.4

@yegor256
Copy link
Owner Author

@krzyk thanks!

@0crat 0crat removed the scope label Dec 25, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

The job #848 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

Order was finished: +30 point(s) just awarded to @krzyk/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants