Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested classes should have since tags #743

Closed
krzyk opened this issue Mar 3, 2016 · 34 comments
Closed

Nested classes should have since tags #743

krzyk opened this issue Mar 3, 2016 · 34 comments

Comments

@krzyk
Copy link
Collaborator

krzyk commented Mar 3, 2016

Nested (static and non-static) classes should have @since tags similarly what we have now for main class.

Innorrect:

/**
 * Some.
 *
 * @since 2.78
 */
public final class Some {
...

    /**
     * Other.
     */
     private final static class Other {
    ...
    }
}

Correct:

/**
 * Some.
 *
 * @since 2.78
 */
public final class Some {
...

    /**
     * Other.
     *
     * @since 3.14
     */
     private final static class Other {
    ...
    }
}
@krzyk
Copy link
Collaborator Author

krzyk commented Mar 3, 2016

@yegor256 Could you take a look? I'm not sure which way is more along your style, forbidding the tags nested classes, or forcing them.

@yegor256
Copy link
Owner

yegor256 commented Mar 5, 2016

@krzyk good question. I think it's better to have them for each class, both nested and normal

@krzyk krzyk changed the title Nested classes shouldn't have author, version and since tags Nested classes should have author, version and since tags Mar 5, 2016
@krzyk
Copy link
Collaborator Author

krzyk commented Mar 5, 2016

@yegor256 thanks, I've updated the description/title

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 5, 2016

@davvd valid bug

@davvd
Copy link

davvd commented Mar 7, 2016

@davvd valid bug

@krzyk I added bug tag to this ticket

@davvd
Copy link

davvd commented Mar 15, 2016

@krzyk thank you for reporting this, I added 30 mins to your acc, transaction 80479648

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 29, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Mar 30, 2016

@davvd this is postponed

@krzyk sure, thanks, I added "postponed" label to it

@davvd
Copy link

davvd commented Mar 30, 2016

@davvd this is postponed

@krzyk all right, we'll find someone else for this task

@krzyk
Copy link
Collaborator Author

krzyk commented May 1, 2018

@0crat in

@0crat 0crat added the scope label May 1, 2018
@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@0crat in (here)

@krzyk Job #743 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 7, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 12, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 17, 2018

@krzyk/z everybody who has role DEV are banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 22, 2018

@krzyk/z everybody who has role DEV is banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 27, 2018

@krzyk/z everybody who has role DEV is banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2018

@krzyk/z everybody who has role DEV is banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

@krzyk/z everybody who has role DEV is banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 11, 2018

@krzyk/z everybody who has role DEV is banned at #743; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@paulodamaso
Copy link
Contributor

@krzyk Author and version tags are prohibited, please correct puzzle.

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 18, 2019

@paulodamaso there is no author or version tag here, which puzzle do you mean?

@paulodamaso
Copy link
Contributor

@krzyk Sorry, I mean ticket description: "Nested classes should have author, version and since tags" is wrong because we do not have version and author tags anymore

@krzyk krzyk changed the title Nested classes should have author, version and since tags Nested classes should have since tags Jan 18, 2019
@krzyk
Copy link
Collaborator Author

krzyk commented Jan 18, 2019

@paulodamaso Oh, thanks, I didn't notice that.

paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 23, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@0pdd
Copy link
Collaborator

0pdd commented Jan 24, 2019

@krzyk the puzzle #1004 is still not solved.

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 24, 2019

@paulodamaso thanks

@krzyk krzyk closed this as completed Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

The job #743 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Jan 30, 2019

@krzyk the only puzzle #1004 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants