Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check to ensure empty lines are present where needed #576

Closed
mkordas opened this issue Jan 1, 2016 · 24 comments
Closed

No check to ensure empty lines are present where needed #576

mkordas opened this issue Jan 1, 2016 · 24 comments
Assignees

Comments

@mkordas
Copy link
Contributor

mkordas commented Jan 1, 2016

Right now the following code passes Qulice check:

@Override
public void start() {
}
@Override
public void stop() {
}

I'd expect violation about missing newline between methods, but EmptyLineSeparator Checkstyle check that was created for that purpose is missing from the config.

@krzyk
Copy link
Collaborator

krzyk commented Jan 2, 2016

@davvd valid bug

@krzyk
Copy link
Collaborator

krzyk commented Jan 2, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Jan 4, 2016

@davvd valid bug

@krzyk I tagged this as "bug"

@davvd
Copy link

davvd commented Jan 4, 2016

@davvd this is postponed

@krzyk thanks, I added "postponed" label

@davvd
Copy link

davvd commented Jan 4, 2016

@davvd this is postponed

@krzyk I will assign somebody else to this issue

@davvd
Copy link

davvd commented Jan 6, 2016

@mkordas thanks for this report, I added 15 mins to your account, in transaction 568d16ae293a7942d800037d

@krzyk
Copy link
Collaborator

krzyk commented Jun 25, 2016

@davvd this is not posptoned

@krzyk
Copy link
Collaborator

krzyk commented Jun 25, 2016

@davvd this is urgent

@davvd
Copy link

davvd commented Jun 27, 2016

@davvd this is urgent

@krzyk right, I added "urgent" label

@davvd davvd added urgent and removed postponed labels Jun 27, 2016
@davvd
Copy link

davvd commented Jun 27, 2016

@davvd this is urgent

@krzyk sure, thanks, I removed "postponed" tags to it

@davvd davvd mentioned this issue Aug 5, 2016
@krzyk
Copy link
Collaborator

krzyk commented Aug 5, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Aug 5, 2016

@davvd this is postponed

@krzyk sure, thanks, I added "postponed" label to it

@davvd davvd added the postponed label Aug 5, 2016
@davvd
Copy link

davvd commented Aug 5, 2016

@davvd this is postponed

@krzyk sure, thanks, I removed "urgent" tags to it

@davvd
Copy link

davvd commented Aug 5, 2016

@davvd this is postponed

@krzyk no problem, I will try to find somebody else

@davvd davvd removed the urgent label Aug 5, 2016
@krzyk
Copy link
Collaborator

krzyk commented Jul 28, 2018

@0crat assign me

@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

@0crat assign me (here)

@krzyk Thanks for your contribution, @mkordas/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

@0crat assign me (here)

@krzyk The job #576 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Aug 2, 2018

@krzyk/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

krzyk added a commit to krzyk/qulice that referenced this issue Aug 10, 2018
@krzyk
Copy link
Collaborator

krzyk commented Aug 10, 2018

@mkordas changes have been merged to master in #922 please close this issue

@krzyk
Copy link
Collaborator

krzyk commented Aug 24, 2018

@mkordas ping

@mkordas
Copy link
Contributor Author

mkordas commented Aug 24, 2018

@krzyk looks good, thanks

@mkordas mkordas closed this as completed Aug 24, 2018
@0crat 0crat removed the scope label Aug 24, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 24, 2018

Order was finished: +30 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Aug 24, 2018

The job #576 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants