Non-excluded files collection moved into a separate method

Author: Polina Volkhontseva

qulice-pmd/src/main/java/com/qulice/pmd/PmdValidator.java

@@ -63,15 +63,7 @@ public PmdValidator(final Environment env) {
     @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     public Collection<Violation> validate(final Collection<File> files) {
         final SourceValidator validator = new SourceValidator(this.env);
-        final Collection<DataSource> sources = new LinkedList<>();
-        for (final File file : files) {
-            final String name = file.getPath().substring(
-                this.env.basedir().toString().length()
-            );
-            if (!this.env.exclude("pmd", name)) {
-                sources.add(new FileDataSource(file));
-            }
-        }
+        final Collection<DataSource> sources = this.getNonExcludedFiles(files);
         final Collection<RuleViolation> breaches = validator.validate(
             sources, this.env.basedir().getPath()
         );
@@ -98,4 +90,21 @@ public String name() {
         return "PMD";
     }
 
+    /**
+     * Filters out excluded files from further validation.
+     * @param files Files to validate
+     * @return Relevant source files
+     */
+    public Collection<DataSource> getNonExcludedFiles(final Collection<File> files) {
+        final Collection<DataSource> sources = new LinkedList<>();
+        for (final File file : files) {
+            final String name = file.getPath().substring(
+                this.env.basedir().toString().length()
+            );
+            if (!this.env.exclude("pmd", name)) {
+                sources.add(new FileDataSource(file));
+            }
+        }
+        return sources;
+    }
 }