For #1000: Added String.length comparison check tests

Author: paulodamaso

qulice-pmd/src/test/java/com/qulice/pmd/UseStringIsEmptyRuleTest.java

@@ -36,12 +36,19 @@
 import org.junit.Test;
 
 /**
- * Test case for {@link UseStringIsEmptyRule}.
+ * Test case for {@link com.qulice.pmd.rules.UseStringIsEmptyRule}.
  * @since 0.18
- * @todo #950:30min UseStringIsEmptyRuleTest is not comparing all possible
- *  targets. Implement the tests for the remaining targets (see complete list in
- *  UseStringIsEmptyRule#getComparisonTargets).
+ * @todo #1000:30min UseStringIsEmptyRuleTest is not comparing all possible
+ *  targets. Implement the tests for the remaining targets (see
+ *  complete list in UseStringIsEmptyRule#getComparisonTargets). Conditions
+ *  that must be tested are checking string length when the String is the
+ *  result of a method (this.method().length()) and when the String is a class
+ *  field (this.somestring.length()). Use the same name and file pattern used
+ *  in the test methods, appending 'This' or 'Method' suffix to indicate
+ *  which access type the test relates to (field or method), renaming the
+ *  tests if needed.
  */
+@SuppressWarnings("PMD.TooManyMethods")
 public final class UseStringIsEmptyRuleTest {
 
     /**
@@ -50,6 +57,36 @@ public final class UseStringIsEmptyRuleTest {
     private static final String ERR_MESSAGE =
         "Use String.isEmpty() when checking for empty string";
 
+    /**
+     * UseStringIsEmptyRule can detect when String.length() < 1,
+     * when the String is a local variable.
+     * @throws Exception If something goes wrong
+     */
+    @Test
+    public void detectsLengthLessThanOne() throws Exception {
+        new PmdAssert(
+            "StringLengthLessThanOne.java", Matchers.is(false),
+            Matchers.containsString(
+                UseStringIsEmptyRuleTest.ERR_MESSAGE
+            )
+        ).validate();
+    }
+
+    /**
+     * UseStringIsEmptyRule can detect when String.length() > 0,
+     * when the String is a local variable.
+     * @throws Exception If something goes wrong
+     */
+    @Test
+    public void detectsLengthGreaterThanZero() throws Exception {
+        new PmdAssert(
+            "StringLengthGreaterThanZero.java", Matchers.is(false),
+            Matchers.containsString(
+                UseStringIsEmptyRuleTest.ERR_MESSAGE
+            )
+        ).validate();
+    }
+
     /**
      * UseStringIsEmptyRule can detect when String.length() is compared to 0.
      * @throws Exception If something goes wrong
@@ -64,6 +101,36 @@ public void detectsLengthEqualsZero() throws Exception {
         ).validate();
     }
 
+    /**
+     * UseStringIsEmptyRule can detect when String.length() != 1,
+     * when the String is a local variable.
+     * @throws Exception If something goes wrong
+     */
+    @Test
+    public void detectsLengthNotEqualsZero() throws Exception {
+        new PmdAssert(
+            "StringLengthNotEqualsZero.java", Matchers.is(false),
+            Matchers.containsString(
+                UseStringIsEmptyRuleTest.ERR_MESSAGE
+            )
+        ).validate();
+    }
+
+    /**
+     * UseStringIsEmptyRule can detect when String.length() >= 0,
+     * when the String is returned by a method.
+     * @throws Exception If something goes wrong
+     */
+    @Test
+    public void detectsLengthGreaterOrEqualZero() throws Exception {
+        new PmdAssert(
+            "StringLengthGreaterOrEqualZero.java", Matchers.is(false),
+            Matchers.containsString(
+                UseStringIsEmptyRuleTest.ERR_MESSAGE
+            )
+        ).validate();
+    }
+
     /**
      * UseStringIsEmptyRule can detect when String.length() >= 1,
      * when the String is returned by a method.
@@ -72,22 +139,22 @@ public void detectsLengthEqualsZero() throws Exception {
     @Test
     public void detectsLengthGreaterOrEqualOne() throws Exception {
         new PmdAssert(
-            "StringFromMethodLength.java", Matchers.is(false),
+            "StringLengthGreaterOrEqualOne.java", Matchers.is(false),
             Matchers.containsString(
                 UseStringIsEmptyRuleTest.ERR_MESSAGE
             )
         ).validate();
     }
 
     /**
-     * UseStringIsEmptyRule can detect when String.length() < 1,
+     * UseStringIsEmptyRule can detect when String.length() <= 0,
      * when the String is a local variable.
      * @throws Exception If something goes wrong
      */
     @Test
-    public void detectsLengthLessThanOne() throws Exception {
+    public void detectsLengthLessOrEqualZero() throws Exception {
         new PmdAssert(
-            "LocalStringLength.java", Matchers.is(false),
+            "StringLengthLessOrEqualZero.java", Matchers.is(false),
             Matchers.containsString(
                 UseStringIsEmptyRuleTest.ERR_MESSAGE
             )

qulice-pmd/src/test/resources/com/qulice/pmd/LocalStringLength.java

@@ -2,13 +2,7 @@
 
 public final class StringLengthEqualsZero {
 
-    private final String somestring;
-
-    public StringLengthEqualsZero(final String str) {
-        this.somestring = str;
-    }
-
-    public boolean sizeIsZero() {
+    public boolean sizeIsZero(final String somestring) {
         return somestring.length() == 0;
     }
 

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthEqualsZero.java

@@ -0,0 +1,8 @@
+package foo;
+
+public final class StringLengthGreaterOrEqualOne {
+
+    public boolean sizeGreaterOrEqualOne(final String somestring) {
+        return somestring.length() >= 1;
+    }
+}

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthGreaterOrEqualOne.java

@@ -0,0 +1,8 @@
+package foo;
+
+public final class StringLengthGreaterOrEqualOne {
+
+    public boolean sizeGreaterOrEqualOne(final String somestring) {
+        return somestring.length() >= 0;
+    }
+}

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthGreaterOrEqualZero.java

@@ -0,0 +1,9 @@
+package foo;
+
+public final class StringLengthGreaterThanZero {
+
+    public boolean sizeGreaterThanZero(final String somestring) {
+        return somestring.length() > 0;
+    }
+
+}

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthGreaterThanZero.java

@@ -0,0 +1,15 @@
+package foo;
+
+public final class StringLengthMinorOrEqualsThanZero {
+
+    private final String somestring;
+
+    public StringLengthMinorOrEqualsThanZero(final String str) {
+        this.somestring = str;
+    }
+
+    public boolean sizeMinorOrEqualsThanZero() {
+        return somestring.length() <= 0;
+    }
+
+}

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthLessOrEqualZero.java

@@ -0,0 +1,9 @@
+package foo;
+
+public final class StringLengthLessThanOne {
+
+    public boolean sizeLessThanOne(final String somestring) {
+        return somestring.length() < 1;
+    }
+
+}

qulice-pmd/src/test/resources/com/qulice/pmd/StringLengthLessThanOne.java

@@ -0,0 +1,9 @@
+package foo;
+
+public final class StringLengthNotEqualsZero {
+
+    public boolean sizeIsNotZero(final String somestring) {
+        return somestring.length() != 0;
+    }
+
+}