Skip to content

Commit 09916f5

Browse files
committedJan 28, 2019
For #939: Code review corrections.
1 parent 02e13e4 commit 09916f5

File tree

2 files changed

+36
-3
lines changed

2 files changed

+36
-3
lines changed
 

‎pom.xml

+34-1
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,12 @@
143143
<groupId>org.junit.jupiter</groupId>
144144
<artifactId>junit-jupiter-api</artifactId>
145145
<version>5.3.1</version>
146+
<scope>test</scope>
146147
</dependency>
147148
<dependency>
148149
<groupId>org.junit.jupiter</groupId>
149150
<artifactId>junit-jupiter-engine</artifactId>
150-
<version>5.1.0</version>
151+
<version>5.3.1</version>
151152
<scope>test</scope>
152153
</dependency>
153154
</dependencies>
@@ -191,6 +192,38 @@
191192
</tags>
192193
</configuration>
193194
</plugin>
195+
<plugin>
196+
<artifactId>maven-surefire-plugin</artifactId>
197+
<version>3.0.0-M3</version>
198+
<configuration>
199+
<useFile>false</useFile>
200+
<runOrder>random</runOrder>
201+
<trimStackTrace>false</trimStackTrace>
202+
<failIfNoTests>false</failIfNoTests>
203+
<failIfNoSpecifiedTests>true</failIfNoSpecifiedTests>
204+
<parallel>all</parallel>
205+
<parallelTestsTimeoutInSeconds>0</parallelTestsTimeoutInSeconds>
206+
<parallelTestsTimeoutForcedInSeconds>0</parallelTestsTimeoutForcedInSeconds>
207+
<perCoreThreadCount>true</perCoreThreadCount>
208+
<threadCount>4</threadCount>
209+
</configuration>
210+
</plugin>
211+
<plugin>
212+
<artifactId>maven-failsafe-plugin</artifactId>
213+
<version>3.0.0-M3</version>
214+
<configuration>
215+
<encoding>${project.build.sourceEncoding}</encoding>
216+
<failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>
217+
<forkCount>0</forkCount>
218+
<parallel>all</parallel>
219+
<parallelTestsTimeoutForcedInSeconds>0</parallelTestsTimeoutForcedInSeconds>
220+
<parallelTestsTimeoutInSeconds>0</parallelTestsTimeoutInSeconds>
221+
<perCoreThreadCount>true</perCoreThreadCount>
222+
<runOrder>random</runOrder>
223+
<threadCount>8</threadCount>
224+
<trimStackTrace>false</trimStackTrace>
225+
</configuration>
226+
</plugin>
194227
</plugins>
195228
</pluginManagement>
196229
<plugins>

‎qulice-findbugs/src/test/java/com/qulice/findbugs/FindBugsValidatorTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import com.google.common.base.Joiner;
3333
import com.qulice.spi.Environment;
3434
import com.qulice.spi.ValidationException;
35-
import org.junit.Ignore;
35+
import org.junit.jupiter.api.Disabled;
3636
import org.junit.jupiter.api.Test;
3737

3838
/**
@@ -58,7 +58,7 @@ public void passesCorrectFilesWithNoExceptions() throws Exception {
5858
* FindbugsValidator can report incorrectly added throws.
5959
* @throws Exception If something wrong happens inside
6060
*/
61-
@Ignore
61+
@Disabled
6262
@org.junit.Test(expected = ValidationException.class)
6363
public void reportsIncorrectlyAddedThrows() throws Exception {
6464
final byte[] bytecode = new BytecodeMocker()

0 commit comments

Comments
 (0)
Please sign in to comment.