For #1006: Making ProtectedMethodInFinalClassCheck stricter.

Author: paulodamaso

qulice-checkstyle/src/main/java/com/qulice/checkstyle/ProtectedMethodInFinalClassCheck.java

@@ -91,13 +91,20 @@ private void checkMethods(final DetailAST ast) {
                 objblock, TokenTypes.METHOD_DEF
             )
         ) {
-            if (method.findFirstToken(TokenTypes.MODIFIERS)
-                .findFirstToken(TokenTypes.LITERAL_PROTECTED) != null
-                && !AnnotationUtil.containsAnnotation(method, "Override")) {
-                this.log(
-                    method.getLineNo(),
-                    "Final class should not contain protected methods"
-                );
+            if (method
+                .findFirstToken(TokenTypes.MODIFIERS)
+                .findFirstToken(TokenTypes.LITERAL_PROTECTED) != null) {
+                if (AnnotationUtil.containsAnnotation(method, "Override")) {
+                    this.log(
+                        method.getLineNo(),
+                        "Protected method is overriding default scoped method"
+                    );
+                } else {
+                    this.log(
+                        method.getLineNo(),
+                        "Final class should not contain protected methods"
+                    );
+                }
             }
         }
     }

qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProtectedMethodInFinalClassCheck/Valid.java

@@ -20,11 +20,4 @@ protected void valid() {}
     private abstract static class Foo {
         protected void valid();
     }
-
-    private final static class FooChild extends Foo {
-        @Override
-        protected void valid() {
-            return;
-        }
-    }
 }

qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProtectedMethodInFinalClassCheck/violations.txt

@@ -1,3 +1,4 @@
 9:Final class should not contain protected methods
 11:Final class should not contain protected methods
 14:Final class should not contain protected methods
+22:Protected method is overriding default scoped method