Preparing release v1.70.1 #2211
Merged
+52
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classify 3XX http status code as InvalidArgument
In `serveConnection`, closing the muxed connection instead of underlying `net.Conn` to properly release resources. Muxed connection can be `*tls.Conn` and should be closed properly. Other minor change is close the `stoppedChan` in `serve` at the end as closing it will unblock read in `Close` and will effectively close the listener. This should be the last logical instruction during close.
Map tchannel.ErrCodeBusy to yarpcerrors.CodeResourceExhausted
We currently log them at error level, moving them to warn seems appropriate as they are not server failures in themselves and client is terminating connection. Keeping them logged so we can still debug failures and monitor them.
jronak
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.