Always write report, also in case of errors found #43
+52
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force not only the error exit code suppression, but also writing the report, if the source files contained errors.
Externally documented interface should use "reportLocation", while the internal reporter generator wrapper uses "location". This prevented the report generation too, after suppressing the exit on error by ssetting force=true in options. This will need a fix in Grunt and Gulp tasks too, which used an undocumented interface.
Allow writing the report by promise value { errorMessage, reportLogs }.
This is a breaking change; earlier there was only errorMessage as the value.
* Move the test file for an error case out of the directory with the files for the success case. * Finish the test run in the faling promise callback too.
This was referenced Feb 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
- Coverage 96.87% 96.7% -0.17%
=========================================
Files 22 30 +8
Lines 352 547 +195
=========================================
+ Hits 341 529 +188
- Misses 11 18 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues to attempt fixing #41, builds on #42.
Reject the main promise with both error and report to allow processing of both in case of an error.
Allow writing the report by promise value { errorMessage, reportLogs }. This is a breaking change; earlier there was only errorMessage as the value.