scripts: Optionally disallow additionalProperties at the root #86
+7,128
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
hotfix/scripts/root-additionalProperties
branch
from
b50eefe to
5ac3c05
Compare
maxbrunet
changed the title
|
I have made the change to be opt-in only as it is not absolutely required for a CRD to have a complete schema for build-in fields, since these are implicitly validated. See strimzi/strimzi-kafka-operator#5997 for example. Although, most have them. |
maxbrunet
force-pushed
the
hotfix/scripts/root-additionalProperties
branch
from
1c9332a to
67a73a9
Compare
|
Hi Max, thanks! Could you add a couple of tests to demonstrate the new behaviour of additional_properties? 🙏 Thanks 🙇 |
maxbrunet
force-pushed
the
hotfix/scripts/root-additionalProperties
branch
from
0ed5cac to
30528c5
Compare
|
Done! I have added tests for both |
yannh
approved these changes
Dec 12, 2021
|
Sweet thanks! A unit test would be nice some day but this is good already 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can useful to add
additionalPropertiesto the root of the schema to detect extraneous keys.(the new tests are very nice!)
This also adds a new line at the end of the schema files.