Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XML documentation for string-based Assert.Equal #2880

Closed
bradwilson opened this issue Feb 2, 2024 · 1 comment
Closed

Update XML documentation for string-based Assert.Equal #2880

bradwilson opened this issue Feb 2, 2024 · 1 comment
Labels
area: Assertion library target: 2.x target: 3.0 type: Documentation

Comments

@bradwilson
Copy link
Member

We should make clear that white-space, as influenced by ignoreWhiteSpaceDifferences and ignoreAllWhiteSpace, means horizontal white-space (like space or tab) and not vertical white-space (like carriage return or line feed).

#2440 (comment)
bradwilson added a commit to xunit/assert.xunit that referenced this issue Feb 2, 2024
@bradwilson
xunit/xunit#2880: Update XML documentation for string-based Assert.Equal
3b8edcb
bradwilson added a commit that referenced this issue Feb 2, 2024
@bradwilson
#2880: Update XML documentation for string-based Assert.Equal (v2)
b060404
bradwilson added a commit that referenced this issue Feb 2, 2024
@bradwilson
#2880: Update XML documentation for string-based Assert.Equal (v3)
a4e366b
@bradwilson
Copy link
Member Author

Available in v2: 2.6.7-pre.10
Available in v3: 0.1.1-pre.360

ViktorHofer added a commit to dotnet/arcade that referenced this issue Mar 28, 2024
@ViktorHofer
Squashed 'src/Microsoft.DotNet.XUnitAssert/src/' changes from cb1e33b…
a757c66 
…a6..574aebac4

574aebac4 xunit/xunit#2872: Expand special handling for sets in Assert.Contains/DoesNotContain
3b8edcbf1 xunit/xunit#2880: Update XML documentation for string-based Assert.Equal
d9f8361d2 Consolidate string and span-based Assert.Equal primary implementation
9ad71163e Move span-of-char assertions to StringAsserts and update docs/param names to indicate they're treated like strings
d70b34621 xunit/xunit#2871: Inner exception stack trace is missing from Assert.Collection failure
141681779 Missed #nullable enable in AsyncCollectionAsserts
22c89b0ea xunit/xunit#2367: Add IAsyncEnumerable<> overloads (.NET Core 3.0+)
d5c32630a While formatting type names in Assert.Equal/NotEqual, convert generated type names to '<generated>'
d7b807179 Add platform conditionals to support .NET 6 Roslyn Analyzers
6d9024665 xunit/xunit#2850: Assert.Equal failing value-slot collections of different concrete types (also fixed for KeyValuePair keys and values)
1f66b837a xunit/xunit#2811: Add SortedSet and ImmutableSortedSet overloads for Assert.Contains/DoesNotContain
1dab747d3 Update FuncEqualityComparer to throw if GetHashCode is called, and update EqualException/NotEqualException to process it
6e0a7cd70 xunit/xunit#2828: Prefer IEquatable<> over custom collection equality
c35ef46d5 xunit/xunit#2824: Assert.Equal fails with null values in dictionary
455865ac8 xunit/xunit#2821: Assert.Equal for collections of IEquatable objects don't call custom Equals
9af2c9c12 Clarify names for range comparer
2e6d9b267 Updates for .NET 8 SDK

git-subtree-dir: src/Microsoft.DotNet.XUnitAssert/src
git-subtree-split: 574aebac41dbbbf9e5e98bb9c65c6c5fab9b47f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Assertion library target: 2.x target: 3.0 type: Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradwilson