Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When DomRenderer focus,render the cursor line. #4754

Merged
merged 1 commit into from
Sep 7, 2023
Merged

When DomRenderer focus,render the cursor line. #4754

merged 1 commit into from
Sep 7, 2023

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Sep 7, 2023

fix #4748.

Tyriar
Tyriar approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the test buttons are a nice touch too as this was harder to do in the demo than it should have been.

@Tyriar Tyriar added this to the 5.3.0 milestone Sep 7, 2023
@Tyriar Tyriar self-assigned this Sep 7, 2023
@Tyriar Tyriar merged commit 7b52b8e into xtermjs:master Sep 7, 2023
17 of 18 checks passed
@tisilent tisilent deleted the DomRenderer-Focus-Cursor branch September 7, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

DOM renderer does not re-render cursor on focus
2 participants
@tisilent @Tyriar