Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose blink state manager #4659

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Dispose blink state manager #4659

merged 2 commits into from
Aug 10, 2023

Conversation

SvanT
Copy link
Contributor

@SvanT SvanT commented Aug 10, 2023

@Tyriar microsoft/vscode#187082

I've verified that terminals with blinking cursor are retained before this patch, and this patch fixes it.

@Tyriar Tyriar added this to the 5.3.0 milestone Aug 10, 2023
@Tyriar Tyriar self-assigned this Aug 10, 2023
Tyriar
Tyriar approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll pull it into vscode some time today

@Tyriar Tyriar merged commit bb5d61f into xtermjs:master Aug 10, 2023
8 checks passed
@SvanT SvanT deleted the dispose-blink-state-manager branch August 10, 2023 17:35
@Tyriar Tyriar mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SvanT @Tyriar