Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoothScroll to scrollLines #4482

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Add smoothScroll to scrollLines #4482

merged 9 commits into from
Aug 1, 2023

Conversation

tisilent
Copy link
Contributor

Fix #4121

src/browser/Terminal.ts Outdated Show resolved Hide resolved
src/browser/Terminal.ts Show resolved Hide resolved
@tisilent
Copy link
Contributor Author

tisilent commented Jun 6, 2023

@Tyriar hi. help review.

src/browser/Viewport.ts Outdated Show resolved Hide resolved
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tisilent, I made some changes to fix the tests and pass the scroll to top/bottom/line/pages calls through scrollLines

@Tyriar Tyriar added this to the 5.3.0 milestone Aug 1, 2023
@Tyriar Tyriar self-assigned this Aug 1, 2023
@Tyriar Tyriar merged commit db6e0cd into xtermjs:master Aug 1, 2023
8 checks passed
@tisilent
Copy link
Contributor Author

tisilent commented Aug 1, 2023

Oho @Tyriar , learning to write testsI'm learning to write tests .
I'm thinking about some of the logic of Terminal scrollLine moving to Viewport.
Terminal -> Viewport -> BufferService

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2023

Test coverage is good enough currently, there are unit tests which run in node and use a Mock Viewport and then API tests that actually use the scroll apis in a browser context

@tisilent
Copy link
Contributor Author

tisilent commented Aug 1, 2023

no.no. I learned how to write tests,Thanks @Tyriar

@tisilent
Copy link
Contributor Author

tisilent commented Aug 1, 2023

I’am very sorry I had a wrong to sent the message. @Tyriar
learning to write tests
I'm learning to write tests .
😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smooth scrolling should apply when using Terminal.scroll* APIs
2 participants