Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly parse closing where the last attribute has no value #485

Merged
merged 4 commits into from Mar 31, 2023

Conversation

Bulandent
Copy link
Contributor

@Bulandent Bulandent commented Mar 24, 2023

Closes #486

@Bulandent Bulandent changed the title resolving tags without attribute values causes confusion fix: resolving tags without attribute values causes confusion Mar 24, 2023
@karfau
Copy link
Member

karfau commented Mar 24, 2023

Since all tests are green, it means nothing covered that condition yet. Would be great to add your test case to the PR,
so it never breaks again.

Do you want to try it?

@Bulandent
Copy link
Contributor Author

Since all tests are green, it means nothing covered that condition yet. Would be great to add your test case to the PR, so it never breaks again.

Do you want to try it?

Ok, I haved push the test case about without attr values。

@karfau
Copy link
Member

karfau commented Mar 28, 2023

Awesome.
I needed to revert the lock file you pushed.
And I will take the time within this week to try to understand the change a bit better, before I will land it and publish the next 0.7 and 0.8 release with this fix.
Thx for you contribution and investment.

@Bulandent
Copy link
Contributor Author

Awesome. I needed to revert the lock file you pushed. And I will take the time within this week to try to understand the change a bit better, before I will land it and publish the next 0.7 and 0.8 release with this fix. Thx for you contribution and investment.

You are welcome. This was my first pr submission for an open source project, and I felt really good about it. 😁

@karfau karfau force-pushed the fix-without_attr_value-0324 branch from 61f1a3f to 59089b8 Compare March 31, 2023 08:27
@karfau
Copy link
Member

karfau commented Mar 31, 2023

I love your solution to the problem.
Will go ahead and land and release.

@karfau karfau merged commit 5c671dc into xmldom:master Mar 31, 2023
22 checks passed
@karfau karfau changed the title fix: resolving tags without attribute values causes confusion fix: properly parse closing where the last attribute has no value Mar 31, 2023
@karfau
Copy link
Member

karfau commented Mar 31, 2023

Fixes are available in 0.7.10 and 0.8.7 releases
(Since I'm still working on something for the upcoming next release 0.9.0-beta.7, this fix will only be included once that version is released.)

karfau added a commit that referenced this pull request Apr 2, 2023
and adding snapshots for warnings

The additional output was introduced by the new tests in #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing an attribute without a value can cause code confusion
2 participants