New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly parse closing where the last attribute has no value #485
Conversation
Since all tests are green, it means nothing covered that condition yet. Would be great to add your test case to the PR, Do you want to try it? |
Ok, I haved push the test case about without attr values。 |
Awesome. |
You are welcome. This was my first pr submission for an open source project, and I felt really good about it. 😁 |
61f1a3f
to
59089b8
Compare
I love your solution to the problem. |
Fixes are available in 0.7.10 and 0.8.7 releases |
and adding snapshots for warnings The additional output was introduced by the new tests in #485
Closes #486